Upload crashes to logs bucket in permissionless way #4400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanmetzman
force-pushed
the
master
branch
from
a714059
to
f4df493
Compare
oliverchang
reviewed
Nov 14, 2024
| if crash_path is None: | ||
| return engine_output | ||
| if os.path.getsize(crash_path) > 10 * 1024**2: | ||
| return engine_output |
There was a problem hiding this comment.
should we log an error ? this seems pretty bad if we're not uploading a testcase right?
There was a problem hiding this comment.
It's just a testcase in logs. Really not that important.
| @@ -534,7 +535,7 @@ def _do_run_testcase_and_return_result_in_queue(crash_queue, | |||
| # Don't upload uninteresting testcases (no crash) or if there is no log to | |||
| # correlate it with (not upload_output). | |||
| if upload_output: | |||
| upload_testcase(file_path, log_time) | |||
| upload_testcase(file_path, log_time, None) | |||
There was a problem hiding this comment.
wrong order of arguments?
There was a problem hiding this comment.
Youre right.
I think because of how many edge cases our code has there's no actual misbehavior resulting from this bug
There was a problem hiding this comment.
WIll fix in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts crashes in the output for uploading. That can probably be replaced with a signed_url.
It can probably be improved if the crash is included elsewhere.