Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Adding a build age metric #4341

Merged
merged 22 commits into from
Nov 13, 2024
Merged

Conversation

vitorguidi
Copy link
Collaborator

@vitorguidi vitorguidi commented Oct 21, 2024

Motivation

We currently lack awareness on how old builds are during fuzz task. This PR implements that, by making the assumption that the Last Update Time metadata field in GCS is a good proxy for build age. Documentation reference

Approach

Symbolized and custom builds do not matter, thus all builds of interest will be fetched from build_manager.setup_regular_build. Logic for collecting all bucket paths and the latest revision was refactored, so that setup_regular_build can also figure out the latest revision for a given build and conditionally emit the proposed metric.

Testing strategy

!Todo: test this for fuzz, analyze, progression

Locally ran tasks, with instructions from #4343 and #4345 , and verified the _emmit_build_age_metric function gets invoked and produces sane output.

Commands used:

fuzz libFuzzer libfuzzer_asan_log4j2

image

progression 4992158360403968 libfuzzer_asan_qt

image

analyze 4992158360403968 libfuzzer_asan_qt (disclaimer: build revision was overriden mid flight to force a trunk build, since this testcase was already tied to a crash revision)

image

Part of #4271

@jonathanmetzman
Copy link
Collaborator

Does this need a review?

@vitorguidi
Copy link
Collaborator Author

Does this need a review?

I am triggering the reviews once the code gets to a good enough state, I will add a WIP tag to the next ones to signal that.

@vitorguidi vitorguidi changed the title Adding a build age metric [Monitoring] Adding a build age metric Nov 8, 2024
Copy link
Collaborator

@alhijazi alhijazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comment

@vitorguidi vitorguidi merged commit 9ee9387 into master Nov 13, 2024
7 checks passed
@vitorguidi vitorguidi deleted the feature/build-time-metrics branch November 13, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants