-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Adding a build age metric #4341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorguidi
commented
Oct 21, 2024
Does this need a review? |
I am triggering the reviews once the code gets to a good enough state, I will add a WIP tag to the next ones to signal that. |
oliverchang
requested changes
Oct 24, 2024
alhijazi
reviewed
Oct 24, 2024
alhijazi
reviewed
Oct 24, 2024
alhijazi
reviewed
Nov 4, 2024
oliverchang
approved these changes
Nov 7, 2024
vitorguidi
changed the title
Adding a build age metric
[Monitoring] Adding a build age metric
Nov 8, 2024
alhijazi
reviewed
Nov 12, 2024
alhijazi
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We currently lack awareness on how old builds are during fuzz task. This PR implements that, by making the assumption that the Last Update Time metadata field in GCS is a good proxy for build age. Documentation reference
Approach
Symbolized and custom builds do not matter, thus all builds of interest will be fetched from
build_manager.setup_regular_build
. Logic for collecting all bucket paths and the latest revision was refactored, so thatsetup_regular_build
can also figure out the latest revision for a given build and conditionally emit the proposed metric.Testing strategy
!Todo: test this for fuzz, analyze, progression
Locally ran tasks, with instructions from #4343 and #4345 , and verified the _emmit_build_age_metric function gets invoked and produces sane output.
Commands used:
Part of #4271