Fix incorrect timeout calculation message and improve variable naming #4010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonasdev
force-pushed
the
fix/timeout-error-message
branch
from
fc3964f
to
c6dd605
Compare
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the incorrect timeout calculation message and improves variable naming in the
run_engine_fuzzerfunction.The error message previously used
fuzz_test_timeoutafter it was adjusted, leading to confusion.For example, before this PR, if
fuzz_test_timeout = 2100andadditional_processing_time = 2700, the error message will show"Invalid engine timeout: -600.0 - 2700.0"which is confusing.This PR ensures the message correctly reflects the original
fuzz_test_timeout.