CMake: install relocatable shared libs for macOS #1089
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hardcoded
CMAKE_INSTALL_NAME_DIR
, so that it's@rpath
by default (default CMake behavior when cmake_minimum_required() is at least 3.0).set(CMAKE_MACOS_RPATH TRUE)
is useless, it's the default value for CMake if cmake_minimum_required() is at least 3.0 as well, no need to hardcode this value.It reverts #976 (hardcoding
CMAKE_INSTALL_NAME_DIR
is bad practice).If someone wants to change this behavior for a specific reason,
CMAKE_INSTALL_NAME_DIR
can be injected externally, no need to patch build files.