Add support for zstd compressed debug sections (#318) #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for processing zstd compressed debug sections. `lld` and associated tools now support using `zstd` in addition to `zlib` for debug info compression, for example: ``` clang++ -gz=zstd foo.cc clang++ -shared -W,--compress-debug-sections=zstd foo.cc llvm-objcopy --compress-debug-sections=zstd foo.o foo-compressed.o ``` This CL: - Adds a dependency on `zstd` - Handles the `ELFCOMPRESS_ZSTD` `ch_type` flag - Uses `zstd` to decompress sections marked with `ELFCOMPRESS_ZSTD`
|
@haberman Mind taking a look? This doesn't have the cmake hooks, but that's a bit out of my wheelhouse and. cc @walkingeyerobot |
|
@haberman This change enables to inspect Fuchsia OS project binaries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for processing zstd compressed debug sections.
lldand associated tools now support usingzstdin addition tozlibfor debug info compression, for example:This CL:
zstdELFCOMPRESS_ZSTDch_typeflagzstdto decompress sections marked withELFCOMPRESS_ZSTD