Implement TLS1 PRF using the EVP_KDF API in OpenSSL 3 #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
requested review from
ueno,
karianna,
derekparker,
dagood and
gdams
mertakman
reviewed
Sep 16, 2024
|
Review needed. Specially from @ueno. Thanks! |
ueno
approved these changes
Sep 22, 2024
dagood
reviewed
Sep 23, 2024
Co-authored-by: Davis Goodin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EVP_KDF API was added in OpenSSL 3 to properly support KDF algorithms, such as TLS1 PRF. It is recommended that KDF operations migrates from the EVP_PKEY API to this new API. The built-in providers still support the EVP_PKEY for back compat, but third party provider might not do it (SymCrypt looking at you).
This PR implements TLS1 PRF using the EVP_KDF API when using OpenSSL 3.
Also, I'm introducing a new helper,
paramBuilder, to build parameters in a much cleaner and safer way. I'll submit a follow-up PR using this helper in other algorithms.For #158.
For #189.