-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Add-Feature] Add custom DXVK_HUD option #1119
base: master
Are you sure you want to change the base?
Changes from all commits
c8f5b11
7bdd7ae
16c88a9
ba7aabf
77ae3a8
6d108f5
31d377d
a3ed5a1
75b534a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -115,6 +115,7 @@ private static void LoadConfig(Storage storage) | |
Config.DxvkAsyncEnabled ??= true; | ||
Config.ESyncEnabled ??= true; | ||
Config.FSyncEnabled ??= false; | ||
Config.DxvkHudCustomString ??= "fps,frametimes,gpuload,version"; | ||
|
||
Config.WineStartupType ??= WineStartupType.Managed; | ||
Config.WineBinaryPath ??= "/usr/bin"; | ||
|
@@ -276,7 +277,7 @@ public static void CreateCompatToolsInstance() | |
{ | ||
var wineLogFile = new FileInfo(Path.Combine(storage.GetFolder("logs").FullName, "wine.log")); | ||
var winePrefix = storage.GetFolder("wineprefix"); | ||
var wineSettings = new WineSettings(Config.WineStartupType, Config.WineBinaryPath, Config.WineDebugVars, wineLogFile, winePrefix, Config.ESyncEnabled, Config.FSyncEnabled); | ||
var wineSettings = new WineSettings(Config.WineStartupType, Config.WineBinaryPath, Config.DxvkHudCustomString, Config.WineDebugVars, wineLogFile, winePrefix, Config.ESyncEnabled, Config.FSyncEnabled); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably a better idea to not put dxvk related config into Ideally DxvkHudCustomString is in there as well, or even better just put all dxvk related settings into their own class like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also consider that dxvk can also be used on windows, even though this is currently not in the scope of what XL provides it is possible, and for example an option in the GShade windows installer There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using dxvk on Windows is something we should never support. (It also will crash dalamud) It honestly led to a support nightmare when the gshade installer started providing it as an option. DXVK options should only be available for Wine platforms. |
||
var toolsFolder = storage.GetFolder("compatibilitytool"); | ||
CompatibilityTools = new CompatibilityTools(wineSettings, Config.DxvkHudType, Config.GameModeEnabled, Config.DxvkAsyncEnabled, toolsFolder); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit nit-picky but there is an extra space before FileInfo here (well and it is better to not have dxvk stuff here as well)