Implement FPS Limiter (DXVK_FRAME_RATE) #1011
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zi-SH
commented
Jun 4, 2022
| @@ -54,7 +54,6 @@ public SettingsTabWine() | |||
| }, | |||
| new SettingsEntry<string>("DXVK Frame Limit", "Configure how many frames DXVK should be limited to. Set to 0 for unlimited.", () => Program.Config.DxvkFrameRate ?? "0", s => Program.Config.DxvkFrameRate = s) | |||
| { | |||
| CheckVisibility = () => RuntimeInformation.IsOSPlatform(OSPlatform.Linux), | |||
There was a problem hiding this comment.
After discussion with marzent about DXVK on Windows, I've opted to remove Linux-only visibility.
marzent
suggested changes
Jun 25, 2022
| @@ -19,15 +19,18 @@ public class WineSettings | |||
| public string EsyncOn { get; private set; } | |||
| public string FsyncOn { get; private set; } | |||
|
|
|||
| public string DxvkFPSLimit { get; private set; } | |||
There was a problem hiding this comment.
Wouldn't it make more sense to store an fps limit as an integer
| public string DebugVars { get; private set; } | ||
| public FileInfo LogFile { get; private set; } | ||
|
|
||
| public DirectoryInfo Prefix { get; private set; } | ||
|
|
||
| public WineSettings(WineStartupType? startupType, string customBinPath, string debugVars, FileInfo logFile, DirectoryInfo prefix, bool? esyncOn, bool? fsyncOn) | ||
| public WineSettings(WineStartupType? startupType, string customBinPath, string debugVars, FileInfo logFile, DirectoryInfo prefix, bool? esyncOn, bool? fsyncOn, string dxvkFPSLimit) |
There was a problem hiding this comment.
This is not a wine setting and should probably go into the appropriately named Dxvk class
|
|
||
| new SettingsEntry<string>("DXVK Frame Limit", "Configure how many frames DXVK should be limited to. Set to 0 for unlimited.", () => Program.Config.DxvkFrameRate ?? "0", s => Program.Config.DxvkFrameRate = s) | ||
| { | ||
| CheckValidity = s => Regex.IsMatch(s, @"^\d{1,3}$") ? null : "Please specify a valid integer below 999." |
There was a problem hiding this comment.
Regex is a bit overkill to check for a non-negative integer; afaik dxvk can also limit to more than 999fps
| @@ -72,6 +72,8 @@ public interface ILauncherConfig | |||
|
|
|||
| public bool? FSyncEnabled { get; set; } | |||
|
|
|||
| public string DxvkFrameRate { get; set; } | |||
There was a problem hiding this comment.
Same as earlier this does not need to be a string
|
I don't have access to my system for another week, but I'll review it after I return. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmitting #948 with fix for merge conflict and a few changes for Linux-only visibility.
I've been playing with this setting for a while and I've not had any issues with DXVK's frame limiter.