Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency Tracker 1.3.4.4 #3269

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Currency Tracker 1.3.4.4 #3269

merged 5 commits into from
Mar 8, 2024

Conversation

AtmoOmen
Copy link
Contributor

@AtmoOmen AtmoOmen commented Mar 8, 2024

  • Fixed an issue that other modules could not be unloaded normally due to one single module unload error.
  • Fixed an issue that fails to switch the view of main window.
  • Fixed an issue that adds empty retainers to the config in some special cases.
  • Fixed an issue that some transactions quest names being lost.
  • Refactored most of the modules.

Most of the diffs are from the format cleanup.

@bleatbot bleatbot enabled auto-merge (squash) March 8, 2024 13:35
@bleatbot
Copy link
Collaborator

bleatbot commented Mar 8, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently more than a day.

❌CurrencyTracker [stable] - ed62265 - Build failed (Diff)

Show log - Review

@bleatbot bleatbot added the build failed This plugin failed to build. label Mar 8, 2024
auto-merge was automatically disabled March 8, 2024 13:48

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Mar 8, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

❌CurrencyTracker [stable] - 0ab0e5c - Build failed (Diff)

Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Mar 8, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

❌CurrencyTracker [stable] - da6b8d3 - Build failed (Diff)

Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Mar 8, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

❌CurrencyTracker [stable] - e9afe23 - Build failed (Diff)

Show log - Review

@AtmoOmen
Copy link
Contributor Author

AtmoOmen commented Mar 8, 2024

[14:26:30 INF] /usr/share/dotnet/sdk/7.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(376,5): error NETSDK1073: The FrameworkReference 'Microsoft.WindowsDesktop.App.WindowsForms' was not recognized [/work/repo/CurrencyTracker/CurrencyTracker.csproj]

WTF?

@bleatbot
Copy link
Collaborator

bleatbot commented Mar 8, 2024

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️CurrencyTracker [stable] - cf98c0c - v1.3.4.4 - Diff (1121 lines, prev. 1.3.4.3)

Show log - Review

@bleatbot bleatbot added size-large Diff for this PR is large. and removed build failed This plugin failed to build. labels Mar 8, 2024
@philpax philpax merged commit c294e40 into goatcorp:main Mar 8, 2024
2 checks passed
@AtmoOmen AtmoOmen deleted the patch-1 branch March 9, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-large Diff for this PR is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants