Add workspace_path and JSON pointer command template parameters.
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also set the env var ACTION_WORKSPACE_PATH.
Also implement proper shell escaping of all user-provided quantities.
Reorganize the tutorial to introduce values before groups. Demonstrate using values with command template parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow row to generate commands directly for command line applications. Also properly escape all user-provided strings that are placed in bash scripts.
Motivation and context
Previously, users needed to write a wrapper script in Python that parsed the JSON file and then called
subprocess.run.Resolves #51
How has this been tested?
Extensive unit tests.
Checklist:
doc/src/contributors.md) in the pull request source branch.doc/src/release-notes.md.