Merge pull request prisms-center#235 from landinjm/fix_warnings

Fixed warnings & EquationDependencyParser logic
gjerdej · Sep 10, 2024 · 9bfe086 · 9bfe086
2 parents b6ae462 + ed9694e
commit 9bfe086
Show file tree

Hide file tree

Showing 50 changed files with 415 additions and 404 deletions.
diff --git a/applications/CHAC_anisotropy/customPDE.h b/applications/CHAC_anisotropy/customPDE.h
@@ -14,7 +14,7 @@ class customPDE : public MatrixFreePDE<dim, degree>
   setInitialCondition(const dealii::Point<dim> &p,
                       const unsigned int        index,
                       double                   &scalar_IC,
-                      dealii::Vector<double>   &vector_IC);
+                      dealii::Vector<double>   &vector_IC) override;
 
   // Function to set the non-uniform Dirichlet boundary conditions (in
   // ICs_and_BCs.h)
@@ -24,7 +24,7 @@ class customPDE : public MatrixFreePDE<dim, degree>
                             const unsigned int        direction,
                             const double              time,
                             double                   &scalar_BC,
-                            dealii::Vector<double>   &vector_BC);
+                            dealii::Vector<double>   &vector_BC) override;
 
 private:
 #include "../../include/typeDefs.h"
@@ -36,34 +36,35 @@ class customPDE : public MatrixFreePDE<dim, degree>
   void
   explicitEquationRHS(
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
-    dealii::Point<dim, dealii::VectorizedArray<double>>              q_point_loc) const;
+    dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 
   // Function to set the RHS of the governing equations for all other equations
   // (in equations.h)
   void
   nonExplicitEquationRHS(
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
-    dealii::Point<dim, dealii::VectorizedArray<double>>              q_point_loc) const;
+    dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 
   // Function to set the LHS of the governing equations (in equations.h)
   void
   equationLHS(
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
-    dealii::Point<dim, dealii::VectorizedArray<double>>              q_point_loc) const;
+    dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 
 // Function to set postprocessing expressions (in postprocess.h)
 #ifdef POSTPROCESS_FILE_EXISTS
   void
   postProcessedFields(
     const variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &pp_variable_list,
-    const dealii::Point<dim, dealii::VectorizedArray<double>>        q_point_loc) const;
+    const dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 #endif
 
 // Function to set the nucleation probability (in nucleation.h)
 #ifdef NUCLEATION_FILE_EXISTS
   double
-  getNucleationProbability(variableValueContainer variable_value, double dV) const;
+  getNucleationProbability(variableValueContainer variable_value,
+                           double                 dV) const override;
 #endif
 
   // ================================================================

diff --git a/applications/CHAC_anisotropyRegularized/customPDE.h b/applications/CHAC_anisotropyRegularized/customPDE.h
@@ -14,7 +14,7 @@ class customPDE : public MatrixFreePDE<dim, degree>
   setInitialCondition(const dealii::Point<dim> &p,
                       const unsigned int        index,
                       double                   &scalar_IC,
-                      dealii::Vector<double>   &vector_IC);
+                      dealii::Vector<double>   &vector_IC) override;
 
   // Function to set the non-uniform Dirichlet boundary conditions (in
   // ICs_and_BCs.h)
@@ -24,7 +24,7 @@ class customPDE : public MatrixFreePDE<dim, degree>
                             const unsigned int        direction,
                             const double              time,
                             double                   &scalar_BC,
-                            dealii::Vector<double>   &vector_BC);
+                            dealii::Vector<double>   &vector_BC) override;
 
 private:
 #include "../../include/typeDefs.h"
@@ -36,34 +36,35 @@ class customPDE : public MatrixFreePDE<dim, degree>
   void
   explicitEquationRHS(
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
-    dealii::Point<dim, dealii::VectorizedArray<double>>              q_point_loc) const;
+    dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 
   // Function to set the RHS of the governing equations for all other equations
   // (in equations.h)
   void
   nonExplicitEquationRHS(
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
-    dealii::Point<dim, dealii::VectorizedArray<double>>              q_point_loc) const;
+    dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 
   // Function to set the LHS of the governing equations (in equations.h)
   void
   equationLHS(
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
-    dealii::Point<dim, dealii::VectorizedArray<double>>              q_point_loc) const;
+    dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 
 // Function to set postprocessing expressions (in postprocess.h)
 #ifdef POSTPROCESS_FILE_EXISTS
   void
   postProcessedFields(
     const variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &pp_variable_list,
-    const dealii::Point<dim, dealii::VectorizedArray<double>>        q_point_loc) const;
+    const dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 #endif
 
 // Function to set the nucleation probability (in nucleation.h)
 #ifdef NUCLEATION_FILE_EXISTS
   double
-  getNucleationProbability(variableValueContainer variable_value, double dV) const;
+  getNucleationProbability(variableValueContainer variable_value,
+                           double                 dV) const override;
 #endif
 
   // ================================================================

diff --git a/applications/CHAC_performance_test/customPDE.h b/applications/CHAC_performance_test/customPDE.h
@@ -14,7 +14,7 @@ class customPDE : public MatrixFreePDE<dim, degree>
   setInitialCondition(const dealii::Point<dim> &p,
                       const unsigned int        index,
                       double                   &scalar_IC,
-                      dealii::Vector<double>   &vector_IC);
+                      dealii::Vector<double>   &vector_IC) override;
 
   // Function to set the non-uniform Dirichlet boundary conditions (in
   // ICs_and_BCs.h)
@@ -24,7 +24,7 @@ class customPDE : public MatrixFreePDE<dim, degree>
                             const unsigned int        direction,
                             const double              time,
                             double                   &scalar_BC,
-                            dealii::Vector<double>   &vector_BC);
+                            dealii::Vector<double>   &vector_BC) override;
 
 private:
 #include "../../include/typeDefs.h"
@@ -36,34 +36,35 @@ class customPDE : public MatrixFreePDE<dim, degree>
   void
   explicitEquationRHS(
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
-    dealii::Point<dim, dealii::VectorizedArray<double>>              q_point_loc) const;
+    dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 
   // Function to set the RHS of the governing equations for all other equations
   // (in equations.h)
   void
   nonExplicitEquationRHS(
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
-    dealii::Point<dim, dealii::VectorizedArray<double>>              q_point_loc) const;
+    dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 
   // Function to set the LHS of the governing equations (in equations.h)
   void
   equationLHS(
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
-    dealii::Point<dim, dealii::VectorizedArray<double>>              q_point_loc) const;
+    dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 
 // Function to set postprocessing expressions (in postprocess.h)
 #ifdef POSTPROCESS_FILE_EXISTS
   void
   postProcessedFields(
     const variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &pp_variable_list,
-    const dealii::Point<dim, dealii::VectorizedArray<double>>        q_point_loc) const;
+    const dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 #endif
 
 // Function to set the nucleation probability (in nucleation.h)
 #ifdef NUCLEATION_FILE_EXISTS
   double
-  getNucleationProbability(variableValueContainer variable_value, double dV) const;
+  getNucleationProbability(variableValueContainer variable_value,
+                           double                 dV) const override;
 #endif
 
   // ================================================================

diff --git a/applications/CHiMaD_benchmark1a/customPDE.h b/applications/CHiMaD_benchmark1a/customPDE.h
@@ -14,7 +14,7 @@ class customPDE : public MatrixFreePDE<dim, degree>
   setInitialCondition(const dealii::Point<dim> &p,
                       const unsigned int        index,
                       double                   &scalar_IC,
-                      dealii::Vector<double>   &vector_IC);
+                      dealii::Vector<double>   &vector_IC) override;
 
   // Function to set the non-uniform Dirichlet boundary conditions (in
   // ICs_and_BCs.h)
@@ -24,7 +24,7 @@ class customPDE : public MatrixFreePDE<dim, degree>
                             const unsigned int        direction,
                             const double              time,
                             double                   &scalar_BC,
-                            dealii::Vector<double>   &vector_BC);
+                            dealii::Vector<double>   &vector_BC) override;
 
 private:
 #include "../../include/typeDefs.h"
@@ -36,34 +36,35 @@ class customPDE : public MatrixFreePDE<dim, degree>
   void
   explicitEquationRHS(
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
-    dealii::Point<dim, dealii::VectorizedArray<double>>              q_point_loc) const;
+    dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 
   // Function to set the RHS of the governing equations for all other equations
   // (in equations.h)
   void
   nonExplicitEquationRHS(
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
-    dealii::Point<dim, dealii::VectorizedArray<double>>              q_point_loc) const;
+    dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 
   // Function to set the LHS of the governing equations (in equations.h)
   void
   equationLHS(
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
-    dealii::Point<dim, dealii::VectorizedArray<double>>              q_point_loc) const;
+    dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 
 // Function to set postprocessing expressions (in postprocess.h)
 #ifdef POSTPROCESS_FILE_EXISTS
   void
   postProcessedFields(
     const variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &pp_variable_list,
-    const dealii::Point<dim, dealii::VectorizedArray<double>>        q_point_loc) const;
+    const dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 #endif
 
 // Function to set the nucleation probability (in nucleation.h)
 #ifdef NUCLEATION_FILE_EXISTS
   double
-  getNucleationProbability(variableValueContainer variable_value, double dV) const;
+  getNucleationProbability(variableValueContainer variable_value,
+                           double                 dV) const override;
 #endif
 
   // ================================================================

diff --git a/applications/CHiMaD_benchmark2a/customPDE.h b/applications/CHiMaD_benchmark2a/customPDE.h
@@ -14,7 +14,7 @@ class customPDE : public MatrixFreePDE<dim, degree>
   setInitialCondition(const dealii::Point<dim> &p,
                       const unsigned int        index,
                       double                   &scalar_IC,
-                      dealii::Vector<double>   &vector_IC);
+                      dealii::Vector<double>   &vector_IC) override;
 
   // Function to set the non-uniform Dirichlet boundary conditions (in
   // ICs_and_BCs.h)
@@ -24,7 +24,7 @@ class customPDE : public MatrixFreePDE<dim, degree>
                             const unsigned int        direction,
                             const double              time,
                             double                   &scalar_BC,
-                            dealii::Vector<double>   &vector_BC);
+                            dealii::Vector<double>   &vector_BC) override;
 
 private:
 #include "../../include/typeDefs.h"
@@ -36,34 +36,35 @@ class customPDE : public MatrixFreePDE<dim, degree>
   void
   explicitEquationRHS(
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
-    dealii::Point<dim, dealii::VectorizedArray<double>>              q_point_loc) const;
+    dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 
   // Function to set the RHS of the governing equations for all other equations
   // (in equations.h)
   void
   nonExplicitEquationRHS(
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
-    dealii::Point<dim, dealii::VectorizedArray<double>>              q_point_loc) const;
+    dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 
   // Function to set the LHS of the governing equations (in equations.h)
   void
   equationLHS(
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
-    dealii::Point<dim, dealii::VectorizedArray<double>>              q_point_loc) const;
+    dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 
 // Function to set postprocessing expressions (in postprocess.h)
 #ifdef POSTPROCESS_FILE_EXISTS
   void
   postProcessedFields(
     const variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &pp_variable_list,
-    const dealii::Point<dim, dealii::VectorizedArray<double>>        q_point_loc) const;
+    const dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 #endif
 
 // Function to set the nucleation probability (in nucleation.h)
 #ifdef NUCLEATION_FILE_EXISTS
   double
-  getNucleationProbability(variableValueContainer variable_value, double dV) const;
+  getNucleationProbability(variableValueContainer variable_value,
+                           double                 dV) const override;
 #endif
 
   // ================================================================

diff --git a/applications/CHiMaD_benchmark3/customPDE.h b/applications/CHiMaD_benchmark3/customPDE.h
@@ -14,7 +14,7 @@ class customPDE : public MatrixFreePDE<dim, degree>
   setInitialCondition(const dealii::Point<dim> &p,
                       const unsigned int        index,
                       double                   &scalar_IC,
-                      dealii::Vector<double>   &vector_IC);
+                      dealii::Vector<double>   &vector_IC) override;
 
   // Function to set the non-uniform Dirichlet boundary conditions (in
   // ICs_and_BCs.h)
@@ -24,7 +24,7 @@ class customPDE : public MatrixFreePDE<dim, degree>
                             const unsigned int        direction,
                             const double              time,
                             double                   &scalar_BC,
-                            dealii::Vector<double>   &vector_BC);
+                            dealii::Vector<double>   &vector_BC) override;
 
 private:
 #include "../../include/typeDefs.h"
@@ -36,34 +36,35 @@ class customPDE : public MatrixFreePDE<dim, degree>
   void
   explicitEquationRHS(
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
-    dealii::Point<dim, dealii::VectorizedArray<double>>              q_point_loc) const;
+    dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 
   // Function to set the RHS of the governing equations for all other equations
   // (in equations.h)
   void
   nonExplicitEquationRHS(
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
-    dealii::Point<dim, dealii::VectorizedArray<double>>              q_point_loc) const;
+    dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 
   // Function to set the LHS of the governing equations (in equations.h)
   void
   equationLHS(
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
-    dealii::Point<dim, dealii::VectorizedArray<double>>              q_point_loc) const;
+    dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 
 // Function to set postprocessing expressions (in postprocess.h)
 #ifdef POSTPROCESS_FILE_EXISTS
   void
   postProcessedFields(
     const variableContainer<dim, degree, dealii::VectorizedArray<double>> &variable_list,
     variableContainer<dim, degree, dealii::VectorizedArray<double>> &pp_variable_list,
-    const dealii::Point<dim, dealii::VectorizedArray<double>>        q_point_loc) const;
+    const dealii::Point<dim, dealii::VectorizedArray<double>> q_point_loc) const override;
 #endif
 
 // Function to set the nucleation probability (in nucleation.h)
 #ifdef NUCLEATION_FILE_EXISTS
   double
-  getNucleationProbability(variableValueContainer variable_value, double dV) const;
+  getNucleationProbability(variableValueContainer variable_value,
+                           double                 dV) const override;
 #endif
 
   // ================================================================