Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare-perf: Add positive/negative icons #3815

Conversation

tausbn
Copy link

@tausbn tausbn commented Nov 14, 2024

Sadly there is no Unicode symbol for "green triangle down".

Here's what it looks like in action:
image

Sadly there is no Unicode symbol for "green triangle down".
@tausbn tausbn requested review from asgerf and esbena November 14, 2024 13:23
@tausbn tausbn requested a review from a team as a code owner November 14, 2024 13:23
@tausbn tausbn changed the title compare-perf: Add positive/negative compare-perf: Add positive/negative icons Nov 14, 2024
@asgerf
Copy link
Contributor

asgerf commented Nov 14, 2024

Perhaps this would look better with Codicons. See https://microsoft.github.io/vscode-codicons/dist/codicon.html and WarningIcon.tsx for reference.

@tausbn
Copy link
Author

tausbn commented Nov 14, 2024

Yeah that looks nicer:
image

Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to merge once conflict is resolved

@tausbn tausbn merged commit e25b2b1 into hackathon/compare-perf Nov 14, 2024
13 checks passed
@tausbn tausbn deleted the tausbn/compare-perf-positive-negative-delta-iconongraphy branch November 14, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants