Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add slottable behavior #283

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add slottable behavior #283

wants to merge 1 commit into from

Conversation

keithamus
Copy link
Member

This adds a new @slot decorator for querying/manipulating/listening for slot elements.

This also listens for slotchanged events and calls the setter which can be very useful for running side effects on a slot change.

@keithamus keithamus requested review from a team and koddsson as code owners September 22, 2022 15:46
@keithamus keithamus requested review from a team and removed request for a team and manuelpuyol October 12, 2022 13:49
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

@colebemis
Copy link
Member

I don't feel qualified to review this since I don't have much web component experience. I'll defer to @koddsson for review.

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice functionality 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants