Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(context): enhance code imported by #3413 #4083

Closed
wants to merge 0 commits into from
Closed

Conversation

zjj
Copy link
Contributor

@zjj zjj commented Oct 27, 2024

if it needs to check if the handler is nil, tie c.index shall always ++

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as GitHub Actions.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@appleboy
Copy link
Member

appleboy commented Nov 6, 2024

@zjj Please help to write testing.

@appleboy appleboy added the bug label Nov 6, 2024
@appleboy appleboy added this to the v1.11 milestone Nov 6, 2024
@appleboy appleboy changed the title enhance code imported by #3413 fix(tree): enhance code imported by #3413 Nov 6, 2024
@appleboy appleboy changed the title fix(tree): enhance code imported by #3413 fix(context): enhance code imported by #3413 Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.99%. Comparing base (3dc1cd6) to head (90815bf).
Report is 79 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4083      +/-   ##
==========================================
- Coverage   99.21%   98.99%   -0.22%     
==========================================
  Files          42       44       +2     
  Lines        3182     3387     +205     
==========================================
+ Hits         3157     3353     +196     
- Misses         17       24       +7     
- Partials        8       10       +2     
Flag Coverage Δ
?
-tags "sonic avx" 98.98% <100.00%> (?)
-tags go_json 98.98% <100.00%> (?)
-tags nomsgpack 98.98% <100.00%> (?)
go-1.18 ?
go-1.19 ?
go-1.20 ?
go-1.21 98.99% <100.00%> (-0.22%) ⬇️
go-1.22 98.99% <100.00%> (?)
macos-latest 98.99% <100.00%> (-0.22%) ⬇️
ubuntu-latest 98.99% <100.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zjj
Copy link
Contributor Author

zjj commented Nov 6, 2024

@zjj Please help to write testing.

I would love to write some tests, but with my limited knowledge, I really can't think of how to test this here. ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants