feat(crons): Add queue_incident_occurrence #80842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Produces an IncidentOccurrence message into the monitors-incident-occurrences topic for later issue occurrence dispatching.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80842 +/- ##
==========================================
- Coverage 78.42% 78.41% -0.01%
==========================================
Files 7209 7209
Lines 319618 319641 +23
Branches 44006 44007 +1
==========================================
+ Hits 250646 250653 +7
- Misses 62586 62598 +12
- Partials 6386 6390 +4 |
JoshFerge
reviewed
Nov 15, 2024
JoshFerge
reviewed
Nov 15, 2024
| "clock_tick_ts": int(clock_tick.timestamp()), | ||
| } | ||
|
|
||
| # The incident occurrence should be |
JoshFerge
approved these changes
Nov 15, 2024
evanpurkhiser
deleted the
evanpurkhiser/feat-crons-add-queue-incident-occurrence
branch
evanpurkhiser
added a commit
that referenced
this pull request
Nov 15, 2024
Passes the clock_tick timestamp through mark_failed, which dispatch_incident_occurrence will used to decide how to dispatch the incident_occurrence (through queuing, or directly sending) Requires #80842
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Produces an
IncidentOccurrencemessage into the monitors-incident-occurrences topic for later issue occurrence dispatching.Part of GH-79328