Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devservices): Support migrations in devenv sync for new devservices #80834

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hubertdeng123
Copy link
Member

For users using the new devservices, they should set the USE_NEW_DEVSERVICES in their .env file.

devenv sync will bring up new devservices in preparation for migrations. It will also bring down services brought up with sentry devservices since those will conflict with new devservices ports.

@hubertdeng123 hubertdeng123 requested review from a team as code owners November 15, 2024 17:58
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 15, 2024
Copy link
Member

@IanWoodard IanWoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I thought the plan was to make sentry devservices gracefully use devservices when available / used?

devenv/sync.py Outdated Show resolved Hide resolved
@hubertdeng123
Copy link
Member Author

hmm I thought the plan was to make sentry devservices gracefully use devservices when available / used?

That was the plan, but we thought about it some more and decided against it because we wanted people to get into the habit of usingdevservices instead of sentry devservices. Additionally, working with click was pretty painful to get it to properly call devservices and pass in the appropriate args.

We can add a warning whenever users use sentry devservices if they have the USE_NEW_DEVSERVICES set to encourage them to use devservices instead for starting dependencies.

@asottile-sentry What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants