chore(notifications): move non shim models (NotficationSettingBase & NotificationMessage) #80832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
markstory
reviewed
Nov 15, 2024
There was a problem hiding this comment.
Similar to #80836 we should have a barrel file for sentry.notifications.models so that django can find models.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #80832 +/- ##
========================================
Coverage 78.41% 78.42%
========================================
Files 7206 7212 +6
Lines 319490 319711 +221
Branches 43999 44011 +12
========================================
+ Hits 250522 250719 +197
- Misses 62582 62605 +23
- Partials 6386 6387 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These models dont have dependencies in gs, no tests too 😳
issue ref(#73858)