ref(crons): Add test to incident_occurrence module #80779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-add-test-to-incident-occurrence-module
branch
from
ea62e7a
to
5ff6380
Compare
evanpurkhiser
commented
Nov 14, 2024
Comment on lines
+64
to
+70
| assert mock_create_incident_occurrence.call_count == 1 | ||
| assert mock_create_incident_occurrence.call_args == mock.call( | ||
| checkin, | ||
| [checkin], | ||
| monitor_incidents[0], | ||
| checkin.date_added, | ||
| ) |
There was a problem hiding this comment.
Just validate that we're calling create_incident_occurrence
evanpurkhiser
commented
Nov 14, 2024
Comment on lines
-307
to
-311
| # Human readible failure reason | ||
| assert ( | ||
| occurrence["evidence_display"][0]["value"] | ||
| == "3 timeout, 3 missed and 2 error check-ins detected" | ||
| ) |
There was a problem hiding this comment.
Tested in the incident_occurrences module now
evanpurkhiser
commented
Nov 14, 2024
Comment on lines
-300
to
-305
| assert len(mock_produce_occurrence_to_kafka.mock_calls) == failure_issue_threshold | ||
| # assert that the correct uuid fingerprint was sent | ||
| kwargs = mock_produce_occurrence_to_kafka.call_args.kwargs | ||
| occurrence = kwargs["occurrence"] | ||
| occurrence = occurrence.to_dict() | ||
| assert occurrence["fingerprint"][0] == monitor_incident.grouphash |
There was a problem hiding this comment.
Tested in the incident_occurrences module now
evanpurkhiser
commented
Nov 14, 2024
Comment on lines
-331
to
-336
| assert len(mock_produce_occurrence_to_kafka.mock_calls) == failure_issue_threshold + 1 | ||
| # assert that the correct uuid fingerprint was sent | ||
| kwargs = mock_produce_occurrence_to_kafka.call_args.kwargs | ||
| occurrence = kwargs["occurrence"] | ||
| occurrence = occurrence.to_dict() | ||
| assert occurrence["fingerprint"][0] == monitor_incident.grouphash |
There was a problem hiding this comment.
Tested in the incident_occurrences module now
evanpurkhiser
commented
Nov 14, 2024
Comment on lines
-435
to
-443
| assert len(mock_produce_occurrence_to_kafka.mock_calls) == failure_issue_threshold | ||
| # assert that the correct uuid fingerprint was sent | ||
| kwargs = mock_produce_occurrence_to_kafka.call_args.kwargs | ||
| occurrence = kwargs["occurrence"] | ||
| occurrence = occurrence.to_dict() | ||
| assert occurrence["fingerprint"][0] == monitor_incident.grouphash | ||
|
|
||
| # Human readible failure reason | ||
| assert occurrence["evidence_display"][0]["value"] == "8 timeout check-ins detected" |
There was a problem hiding this comment.
Tested in the incident_occurrences module now
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #80779 +/- ##
=======================================
Coverage 78.41% 78.41%
=======================================
Files 7206 7206
Lines 319492 319492
Branches 44000 44000
=======================================
+ Hits 250515 250518 +3
+ Misses 62590 62587 -3
Partials 6387 6387 |
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-add-test-to-incident-occurrence-module
branch
from
5ff6380
to
b39a77c
Compare
wedamija
approved these changes
Nov 14, 2024
JoshFerge
approved these changes
Nov 14, 2024
This is extracted from mark_failed
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-add-test-to-incident-occurrence-module
branch
from
b39a77c
to
b97f29c
Compare
evanpurkhiser
deleted the
evanpurkhiser/ref-crons-add-test-to-incident-occurrence-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extracted from mark_failed.
Waiting on #80792
Part of GH-79328