Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(new-trace): Updating mongo db span description format. #79738

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix(new-trace): Updating mongo db span description format. #79738

merged 1 commit into from
Oct 25, 2024

Conversation

Abdkhan14
Copy link
Contributor

Before:
Screenshot 2024-10-24 at 6 23 58 PM

After:
Screenshot 2024-10-24 at 6 24 27 PM

@Abdkhan14 Abdkhan14 marked this pull request as ready for review October 24, 2024 22:24
@Abdkhan14 Abdkhan14 requested a review from a team as a code owner October 24, 2024 22:24
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 24, 2024
0Calories
0Calories approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@0Calories 0Calories left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good short term fix, but it would be best if we could pretty print the JSON here rather than text-wrap, similar to the query summary page:
image

We can truncate via ClippedBox component so that the query doesn't take up too much space

@Abdkhan14 Abdkhan14 merged commit 9cbf811 into master Oct 25, 2024
45 checks passed
@Abdkhan14 Abdkhan14 deleted the abdk/trace-mongo-db-description branch October 25, 2024 15:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@0Calories 0Calories 0Calories approved these changes

@JonasBa JonasBa JonasBa approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Abdkhan14 @JonasBa @0Calories