Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issues): Add project id to partition key for occurrences #79711

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

roggenkemper
Copy link
Member

@roggenkemper roggenkemper commented Oct 24, 2024

this pr adds the project id to the partition key for occurrences. for some issue types, there is only 1 fingerprint so we want to spread those issues across partitions

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #79711   +/-   ##
=======================================
  Coverage   78.45%   78.46%           
=======================================
  Files        7146     7146           
  Lines      316039   316047    +8     
  Branches    43488    43489    +1     
=======================================
+ Hits       247957   247973   +16     
+ Misses      61748    61740    -8     
  Partials     6334     6334           

Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof... that was probably a big problem

@roggenkemper roggenkemper merged commit bbdfad6 into master Oct 30, 2024
51 checks passed
@roggenkemper roggenkemper deleted the roggenkemper/editpartitionkey branch October 30, 2024 20:49
MichaelSun48 pushed a commit that referenced this pull request Oct 31, 2024
this pr adds the project id to the partition key for occurrences. for
some issue types, there is only 1 fingerprint so we want to spread those
issues across partitions
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants