Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sentry apps): remove shims #79321

Merged
merged 5 commits into from
Oct 24, 2024
Merged

chore(sentry apps): remove shims #79321

merged 5 commits into from
Oct 24, 2024

Conversation

Christinarlong
Copy link
Contributor

@Christinarlong Christinarlong commented Oct 17, 2024

Remove the import shims from sentry after gs updates - also fixes any nits I missed

gs ref (https://github.com/getsentry/getsentry/pull/15410)
issue ref(#73857

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 17, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #79321       +/-   ##
===========================================
+ Coverage   52.40%   78.43%   +26.03%     
===========================================
  Files        7117     7122        +5     
  Lines      314681   314825      +144     
  Branches    43317    43301       -16     
===========================================
+ Hits       164905   246932    +82027     
+ Misses     148244    61570    -86674     
- Partials     1532     6323     +4791     

@Christinarlong Christinarlong merged commit c750c7e into master Oct 24, 2024
50 checks passed
@Christinarlong Christinarlong deleted the remove-sa-shims branch October 24, 2024 20:53
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants