fix(profiling) use a int formatter for sample counts (#79621)

Samples dont need float precision
getsentry · Oct 23, 2024 · c5ee901 · c5ee901
1 parent 6bf9006
commit c5ee901
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/static/app/components/profiling/flamegraph/flamegraphTooltip.tsx b/static/app/components/profiling/flamegraph/flamegraphTooltip.tsx
@@ -19,6 +19,8 @@ import type {FlamegraphRenderer} from 'sentry/utils/profiling/renderers/flamegra
 import {Rect} from 'sentry/utils/profiling/speedscope';
 import {relativeChange} from 'sentry/utils/profiling/units/units';
 
+const SAMPLES_FORMATTER = Intl.NumberFormat(undefined, {notation: 'compact'});
+
 export function formatWeightToProfileDuration(
   frame: CallTreeNode,
   flamegraph: Flamegraph
@@ -109,7 +111,7 @@ function DifferentialFlamegraphTooltip(props: DifferentialFlamegraphTooltipProps
         <FlamegraphTooltipColorIndicator
           backgroundColor={formatColorForFrame(props.frame, props.flamegraphRenderer)}
         />
-        {flamegraph.formatter(props.frame.node.totalWeight)}{' '}
+        {SAMPLES_FORMATTER.format(props.frame.node.totalWeight)}{' '}
         {t('samples, ') + formattedChange}{' '}
         {`(${formatWeightToProfileDuration(props.frame.node, flamegraph)})`}{' '}
         {props.frame.frame.name}
@@ -143,8 +145,7 @@ function AggregateFlamegraphTooltip(props: AggregateFlamegraphTooltipProps) {
         <FlamegraphTooltipColorIndicator
           backgroundColor={formatColorForFrame(props.frame, props.flamegraphRenderer)}
         />
-        {props.flamegraphRenderer.flamegraph.formatter(props.frame.node.totalWeight)}{' '}
-        {t('samples') + ' '}
+        {SAMPLES_FORMATTER.format(props.frame.node.totalWeight)} {t('samples') + ' '}
         {`(${formatWeightToProfileDuration(
           props.frame.node,
           props.flamegraphRenderer.flamegraph