-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(grouping): Add checksum grouping variant test inputs (#79655)
This adds three checksum-based inputs to the grouping variant snapshot tests, so I can be sure an upcoming refactor in that area of the code doesn’t break anything. Note: Careful observers will notice that in the resulting snapshots where we store both the raw and hashed checksum, neither one is marked as contributing, and there's no hint explaining by the non-contributing one was ignored. We also don't run the other strategies (message, stacktrace, etc.) the way we do with all other methods of grouping. Fixing either of those felt out of the scope of this PR, but I did leave two `TODO`s so we won't forget to revisit it at some point.
- Loading branch information
1 parent
e381699
commit b357045
Showing
17 changed files
with
134 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
tests/sentry/grouping/grouping_inputs/checksum-no-regex-match-long.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"checksum": "not a legit checksum and also too long a string", | ||
"message": "Dogs are great!" | ||
} |
4 changes: 4 additions & 0 deletions
4
tests/sentry/grouping/grouping_inputs/checksum-no-regex-match.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"checksum": "not a legit checksum", | ||
"message": "Dogs are great!" | ||
} |
4 changes: 4 additions & 0 deletions
4
tests/sentry/grouping/grouping_inputs/checksum-regex-match.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"checksum": "11212012123120120415201309082013", | ||
"message": "Dogs are great!" | ||
} |
12 changes: 12 additions & 0 deletions
12
...ts/test_variants/test_event_hash_variant/legacy@2019_03_12/checksum_no_regex_match.pysnap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
--- | ||
created: '2024-10-23T23:31:04.165771+00:00' | ||
creator: sentry | ||
source: tests/sentry/grouping/test_variants.py | ||
--- | ||
checksum: | ||
hash: "not a legit checksum" | ||
hashed: false | ||
-------------------------------------------------------------------------- | ||
hashed-checksum: | ||
hash: "de46d023e69b171b90ccf3ebca7aede4" | ||
hashed: true |
8 changes: 8 additions & 0 deletions
8
...st_variants/test_event_hash_variant/legacy@2019_03_12/checksum_no_regex_match_long.pysnap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
created: '2024-10-23T23:31:04.119227+00:00' | ||
creator: sentry | ||
source: tests/sentry/grouping/test_variants.py | ||
--- | ||
hashed-checksum: | ||
hash: "2c2e85a6e73109222f131228ed06a7af" | ||
hashed: true |
8 changes: 8 additions & 0 deletions
8
...shots/test_variants/test_event_hash_variant/legacy@2019_03_12/checksum_regex_match.pysnap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
created: '2024-10-23T23:31:04.207745+00:00' | ||
creator: sentry | ||
source: tests/sentry/grouping/test_variants.py | ||
--- | ||
checksum: | ||
hash: "11212012123120120415201309082013" | ||
hashed: false |
12 changes: 12 additions & 0 deletions
12
.../test_variants/test_event_hash_variant/newstyle@2019_05_08/checksum_no_regex_match.pysnap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
--- | ||
created: '2024-10-23T23:31:04.025726+00:00' | ||
creator: sentry | ||
source: tests/sentry/grouping/test_variants.py | ||
--- | ||
checksum: | ||
hash: "not a legit checksum" | ||
hashed: false | ||
-------------------------------------------------------------------------- | ||
hashed-checksum: | ||
hash: "de46d023e69b171b90ccf3ebca7aede4" | ||
hashed: true |
8 changes: 8 additions & 0 deletions
8
..._variants/test_event_hash_variant/newstyle@2019_05_08/checksum_no_regex_match_long.pysnap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
created: '2024-10-23T23:31:03.978728+00:00' | ||
creator: sentry | ||
source: tests/sentry/grouping/test_variants.py | ||
--- | ||
hashed-checksum: | ||
hash: "2c2e85a6e73109222f131228ed06a7af" | ||
hashed: true |
8 changes: 8 additions & 0 deletions
8
...ots/test_variants/test_event_hash_variant/newstyle@2019_05_08/checksum_regex_match.pysnap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
created: '2024-10-23T23:31:04.074740+00:00' | ||
creator: sentry | ||
source: tests/sentry/grouping/test_variants.py | ||
--- | ||
checksum: | ||
hash: "11212012123120120415201309082013" | ||
hashed: false |
12 changes: 12 additions & 0 deletions
12
.../test_variants/test_event_hash_variant/newstyle@2019_10_29/checksum_no_regex_match.pysnap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
--- | ||
created: '2024-10-23T23:31:03.885053+00:00' | ||
creator: sentry | ||
source: tests/sentry/grouping/test_variants.py | ||
--- | ||
checksum: | ||
hash: "not a legit checksum" | ||
hashed: false | ||
-------------------------------------------------------------------------- | ||
hashed-checksum: | ||
hash: "de46d023e69b171b90ccf3ebca7aede4" | ||
hashed: true |
8 changes: 8 additions & 0 deletions
8
..._variants/test_event_hash_variant/newstyle@2019_10_29/checksum_no_regex_match_long.pysnap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
created: '2024-10-23T23:31:03.843495+00:00' | ||
creator: sentry | ||
source: tests/sentry/grouping/test_variants.py | ||
--- | ||
hashed-checksum: | ||
hash: "2c2e85a6e73109222f131228ed06a7af" | ||
hashed: true |
8 changes: 8 additions & 0 deletions
8
...ots/test_variants/test_event_hash_variant/newstyle@2019_10_29/checksum_regex_match.pysnap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
created: '2024-10-23T23:31:03.932140+00:00' | ||
creator: sentry | ||
source: tests/sentry/grouping/test_variants.py | ||
--- | ||
checksum: | ||
hash: "11212012123120120415201309082013" | ||
hashed: false |
12 changes: 12 additions & 0 deletions
12
.../test_variants/test_event_hash_variant/newstyle@2023_01_11/checksum_no_regex_match.pysnap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
--- | ||
created: '2024-10-23T23:31:02.204971+00:00' | ||
creator: sentry | ||
source: tests/sentry/grouping/test_variants.py | ||
--- | ||
checksum: | ||
hash: "not a legit checksum" | ||
hashed: false | ||
-------------------------------------------------------------------------- | ||
hashed-checksum: | ||
hash: "de46d023e69b171b90ccf3ebca7aede4" | ||
hashed: true |
8 changes: 8 additions & 0 deletions
8
..._variants/test_event_hash_variant/newstyle@2023_01_11/checksum_no_regex_match_long.pysnap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
created: '2024-10-23T23:31:00.433039+00:00' | ||
creator: sentry | ||
source: tests/sentry/grouping/test_variants.py | ||
--- | ||
hashed-checksum: | ||
hash: "2c2e85a6e73109222f131228ed06a7af" | ||
hashed: true |
8 changes: 8 additions & 0 deletions
8
...ots/test_variants/test_event_hash_variant/newstyle@2023_01_11/checksum_regex_match.pysnap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
created: '2024-10-23T23:31:03.762694+00:00' | ||
creator: sentry | ||
source: tests/sentry/grouping/test_variants.py | ||
--- | ||
checksum: | ||
hash: "11212012123120120415201309082013" | ||
hashed: false |