Skip to content

Commit

Permalink
add hashing_metadata field to table
Browse files Browse the repository at this point in the history
  • Loading branch information
lobsterkatie committed Nov 11, 2024
1 parent 2f0ac98 commit 346966d
Show file tree
Hide file tree
Showing 3 changed files with 43 additions and 1 deletion.
2 changes: 1 addition & 1 deletion migrations_lockfile.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ hybridcloud: 0016_add_control_cacheversion
nodestore: 0002_nodestore_no_dictfield
remote_subscriptions: 0003_drop_remote_subscription
replays: 0004_index_together
sentry: 0786_drop_broadcasts_cta_column
sentry: 0787_add_hashing_metadata_to_grouphash_metadata
social_auth: 0002_default_auto_field
uptime: 0017_unique_on_timeout
workflow_engine: 0011_action_updates
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# Generated by Django 5.1.1 on 2024-11-08 20:42

from django.db import migrations

import sentry.db.models.fields.jsonfield
from sentry.new_migrations.migrations import CheckedMigration


class Migration(CheckedMigration):
# This flag is used to mark that a migration shouldn't be automatically run in production.
# This should only be used for operations where it's safe to run the migration after your
# code has deployed. So this should not be used for most operations that alter the schema
# of a table.
# Here are some things that make sense to mark as post deployment:
# - Large data migrations. Typically we want these to be run manually so that they can be
# monitored and not block the deploy for a long period of time while they run.
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
# run this outside deployments so that we don't block them. Note that while adding an index
# is a schema change, it's completely safe to run the operation after the code has deployed.
# Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment

is_post_deployment = False

dependencies = [
("sentry", "0786_drop_broadcasts_cta_column"),
]

operations = [
migrations.AddField(
model_name="grouphashmetadata",
name="hashing_metadata",
field=sentry.db.models.fields.jsonfield.JSONField(null=True),
),
]
8 changes: 8 additions & 0 deletions src/sentry/models/grouphashmetadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
from sentry.db.models import Model, region_silo_model
from sentry.db.models.base import sane_repr
from sentry.db.models.fields.foreignkey import FlexibleForeignKey
from sentry.db.models.fields.jsonfield import JSONField
from sentry.types.grouphash_metadata import HashingMetadata


# The overall grouping method used
Expand Down Expand Up @@ -56,6 +58,12 @@ class GroupHashMetadata(Model):
latest_grouping_config = models.CharField(null=True)
# The primary grouping method (message, stacktrace, fingerprint, etc.)
hash_basis = models.CharField(choices=HashBasis, null=True)
# Metadata about the inputs to the hashing process and the hashing process itself (what
# fingerprinting rules were matched? did we parameterize the message? etc.). For the specific
# data stored, see the class definitions of the `HashingMetadata` subtypes.
hashing_metadata: models.Field[HashingMetadata | None, HashingMetadata | None] = JSONField(
null=True
)

# SEER

Expand Down

0 comments on commit 346966d

Please sign in to comment.