-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: network image replay breadcrumb #3933
base: main
Are you sure you want to change the base?
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- network image replay breadcrumb ([#3933](https://github.com/getsentry/sentry-react-native/pull/3933)) If none of the above apply, you can opt out of this check by adding |
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
063bfce | 469.96 ms | 516.38 ms | 46.42 ms |
41db11d | 429.33 ms | 451.24 ms | 21.91 ms |
376301c | 445.52 ms | 474.70 ms | 29.18 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
063bfce | 17.73 MiB | 20.04 MiB | 2.30 MiB |
41db11d | 17.73 MiB | 20.04 MiB | 2.30 MiB |
376301c | 17.73 MiB | 20.04 MiB | 2.30 MiB |
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
063bfce+dirty | 1225.38 ms | 1218.06 ms | -7.31 ms |
41db11d+dirty | 1208.60 ms | 1210.47 ms | 1.87 ms |
376301c+dirty | 1224.74 ms | 1227.00 ms | 2.26 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
063bfce+dirty | 2.92 MiB | 3.61 MiB | 710.22 KiB |
41db11d+dirty | 2.92 MiB | 3.61 MiB | 705.84 KiB |
376301c+dirty | 2.92 MiB | 3.61 MiB | 709.95 KiB |
Android (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
376301c+dirty | 353.80 ms | 388.54 ms | 34.74 ms |
41db11d+dirty | 374.57 ms | 415.25 ms | 40.68 ms |
063bfce+dirty | 338.00 ms | 369.88 ms | 31.88 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
376301c+dirty | 7.15 MiB | 8.31 MiB | 1.17 MiB |
41db11d+dirty | 7.15 MiB | 8.31 MiB | 1.16 MiB |
063bfce+dirty | 7.15 MiB | 8.31 MiB | 1.17 MiB |
Is the situation the same on Android? |
on Android, there are no native request breadcrumbs available for network images - I've checked with the debugger. |
📢 Type of change
📜 Description
The breadcrumb is currently missing for network images. This is what is available in the native breadcrumb:
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps