Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch cron jobs from pubsub to HTTP triggers #872

Merged
merged 19 commits into from
Oct 11, 2024
Merged

Conversation

brian-lou
Copy link
Contributor

@brian-lou brian-lou commented Oct 10, 2024

This PR deprecates pubsub endpoints and switches to HTTP endpoints for triggering cron jobs. This is the first step of the migration. Once this has been merged & is stable, the cron jobs will be redirected away from pubsub. Once this is stable, we will remove the old pubsub endpoints in another PR.

Copy link
Member

@IanWoodard IanWoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave the old way in until the other change is merged so there is no downtime for these cron jobs

src/jobs/index.test.ts Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 96.88196% with 14 lines in your changes missing coverage. Please review.

Project coverage is 90.27%. Comparing base (2e20019) to head (3c471d5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/jobs/slackNotifications.ts 94.11% 4 Missing and 5 partials ⚠️
src/jobs/index.ts 92.30% 4 Missing ⚠️
src/jobs/stalebot.ts 98.41% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
+ Coverage   89.46%   90.27%   +0.80%     
==========================================
  Files         126      131       +5     
  Lines        3693     4142     +449     
  Branches      744      881     +137     
==========================================
+ Hits         3304     3739     +435     
+ Misses        377      366      -11     
- Partials       12       37      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-lou brian-lou merged commit b4cb5b2 into main Oct 11, 2024
10 checks passed
@brian-lou brian-lou deleted the brian/remove-pubusb branch October 11, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants