-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch cron jobs from pubsub to HTTP triggers #872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave the old way in until the other change is merged so there is no downtime for these cron jobs
9a04f21
to
a56aadd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
==========================================
+ Coverage 89.46% 90.27% +0.80%
==========================================
Files 126 131 +5
Lines 3693 4142 +449
Branches 744 881 +137
==========================================
+ Hits 3304 3739 +435
+ Misses 377 366 -11
- Partials 12 37 +25 ☔ View full report in Codecov by Sentry. |
This PR deprecates pubsub endpoints and switches to HTTP endpoints for triggering cron jobs. This is the first step of the migration. Once this has been merged & is stable, the cron jobs will be redirected away from pubsub. Once this is stable, we will remove the old pubsub endpoints in another PR.