Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update traffic after deploy #565

Closed

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Jul 31, 2023

From docs:

To restore sending traffic to the LATEST revision by default, run the [gcloud run services update-traffic](https://cloud.google.com/sdk/gcloud/reference/run/services/update-traffic) command with --to-latest.

Not sure when it started happening, but traffic is not being rerouted to the latest version after deploys. This happens even in a successful deploy job. Example

Hopefully this fixes it

@hubertdeng123 hubertdeng123 changed the title update traffic after deploy Update traffic after deploy Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2cb4d38) 85.05% compared to head (3455684) 85.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #565   +/-   ##
=======================================
  Coverage   85.05%   85.05%           
=======================================
  Files          99       99           
  Lines        2483     2483           
  Branches      484      484           
=======================================
  Hits         2112     2112           
  Misses        365      365           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hubertdeng123 hubertdeng123 requested review from a team July 31, 2023 16:21
@hubertdeng123
Copy link
Member Author

not needed anymore, closing.

@hubertdeng123
Copy link
Member Author

Switching the gcloud service to managed solved our issues of deploys not redirecting traffic to latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant