Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure for Codecov #548

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Configure for Codecov #548

merged 1 commit into from
Jul 26, 2023

Conversation

chadwhitacre
Copy link
Member

@chadwhitacre chadwhitacre commented Jul 25, 2023

Primary PR for #482! 💃 After #545.

Before Deployment

  • Populate GH_APP_PRIVATE_KEY_FOR_CODECOV to GH prod environment.
  • Set a new webhook secret for getsantry (race condition, derp), store it in 1password.
  • Configure webhook and webhook secret in CoveCod ... leave inactive.

After Deployment

@chadwhitacre chadwhitacre mentioned this pull request Jul 25, 2023
43 tasks
status: 'PVTSSF_lADOAH2Fnc4ARzsqzgLXyI4'
responseDue: 'PVTF_lADOAH2Fnc4ARzsqzgLXyhE'
repos:
withoutRouting:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: once there are repos with routing there may be some issues

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Say more?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Maybe this isn't what you mean, but we need to figure out Slack channel routing for notifications. 🤔

Back to #482 for that ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's what I meant here. We will need to configure a channel to send notifications for support, unless we want to also use the #discuss-support-open-source for codecov too.

@chadwhitacre chadwhitacre force-pushed the cwlw/installation-id branch 3 times, most recently from fd00071 to eb2449d Compare July 26, 2023 14:27
Base automatically changed from cwlw/installation-id to main July 26, 2023 14:49
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3f30771) 85.14% compared to head (0bce2af) 85.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #548   +/-   ##
=======================================
  Coverage   85.14%   85.14%           
=======================================
  Files          97       97           
  Lines        2444     2444           
  Branches      479      479           
=======================================
  Hits         2081     2081           
  Misses        357      357           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chadwhitacre
Copy link
Member Author

chadwhitacre commented Jul 26, 2023

Private key and webhook are configured.


Screenshot 2023-07-26 at 11 00 22 AM
Screenshot 2023-07-26 at 11 05 34 AM

@chadwhitacre chadwhitacre merged commit 6b6a0ec into main Jul 26, 2023
7 checks passed
@chadwhitacre chadwhitacre deleted the cwlw/add-codecov branch July 26, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants