Disable routing/triaging for external collaborators #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertdeng123
commented
Jul 25, 2023
| sender?: string, | ||
| state?: string | ||
| ) { | ||
| function makePayload({ repo, label, sender, state, author_association }) { |
There was a problem hiding this comment.
This was becoming overloaded with args, so using an object here instead since it's cleaner and easier to keep track of
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
==========================================
- Coverage 85.18% 84.68% -0.51%
==========================================
Files 98 101 +3
Lines 2450 2520 +70
Branches 480 482 +2
==========================================
+ Hits 2087 2134 +47
- Misses 357 379 +22
- Partials 6 7 +1
☔ View full report in Codecov by Sentry. |
azaslavsky
approved these changes
Jul 26, 2023
hubertdeng123
deleted the
hubertdeng123/disable-routing-triage-external-collaborator
branch
This was referenced Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues keep showing up in 401 dashboard that are created by contractors, this PR disables routing/triaging for them
Example:
getsentry/sentry-dotnet#2501