Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes #6795

Draft
wants to merge 294 commits into
base: v5/develop
Choose a base branch
from
Draft

Changes #6795

wants to merge 294 commits into from

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Nov 14, 2024 •
edited by bastianallgeier
Loading

Known problems

  • content.js: watcher for api endpoint changes calls save request on initial load (should be avoided) and when the API endpoint has already changed
    • the save request goes to the new model, not the old one that it actually applies to
  • FormControls: fix error for preview prop type #6796

Todo

Changelog (in the making)

Features

  • Unsaved changes are stored as changes version on the server
  • Preview Panel view for changes version

Breaking changes

  • All lock routes have been removed
  • Removed Vuex and this.$store
  • Removed k-form-buttons

bastianallgeier and others added 30 commits October 1, 2024 17:50
@bastianallgeier
Merge pull request #6711 from getkirby/v5/changes/kill-vuex
e035b76 
Remove Vuex
@bastianallgeier
Block focus point in image file preview when the model is locked
6f92484
@bastianallgeier
Block all form methods if the content is locked
84a906f
@bastianallgeier
Merge pull request #6713 from getkirby/v5/changes/lock-file-preview
ad1b184 
Block focus point in image file preview when the model is locked
@bastianallgeier
Merge branch 'v5/develop' into v5/changes/develop
9822a12
@bastianallgeier
Merge branch 'v5/develop' into v5/changes/develop
2424366
@distantnative
Remove old Lock classes
2acb9a1
@distantnative
Return Lock object from Panel\Model::lock()
290646d 
 object
@distantnative
Move ::lock() to ModelWithContent
f23bdfb
@distantnative
Deprecate $model->isLocked() method
7662033
@distantnative
Satisfy CI for now
caa312d
@distantnative
Merge branch 'v5/develop' into v5/changes/develop
f80da31 
# Conflicts:
#	panel/package-lock.json
@distantnative
Remove Panel\Controller\Changes::unlock()
8e84ab2
@bastianallgeier
Merge pull request #6719 from getkirby/v5/changes/remove-old-lock-cla…
310615d 
…sses

Remove old Lock classes
@bastianallgeier
Merge pull request #6721 from getkirby/v5/changes/remove-unlock
2458c8a 
Remove `Panel\Controller\Changes::unlock()`
@distantnative
Merge branch 'v5/develop' into v5/changes/develop
3ba1919
@distantnative
cs tweaks
3ff4b01
@bastianallgeier
Merge branch 'v5/develop' into v5/changes/develop
4aa69e9
@bastianallgeier
Fix date in lab example
c16a57f
@bastianallgeier
Extend form controls to show the dropdown for unsaved changes
aab9769
@bastianallgeier
Pass the changes URL to the page and site views
8946eca
@bastianallgeier
Set the lock modification date on update
3f125bf
@bastianallgeier
Wrap the form controls in div to avoid display issues and accept a da…
03cd0cd 
…te object as modified time
@bastianallgeier
Pass the changes URL to the form controls
3386f93
@bastianallgeier
Change the modification timestamp only after the save request went th…
9d73e97 
…rough
@distantnative
Try fixing CI
adf1912
@bastianallgeier
Merge pull request #6727 from getkirby/v5/changes/preview
71f77c6 
New dropdown with preview button
@distantnative
Rename storage handler classes
4706f0a
@bastianallgeier
Merge pull request #6730 from getkirby/v5/changes/rename-storage
c966bb5 
Rename storage handler classes
@bastianallgeier
Remove tracking from the controller and fix the language
4d5c1db
bastianallgeier and others added 27 commits November 13, 2024 14:01
@bastianallgeier
Add the latest version of a translation automatically
1995ec2
@bastianallgeier
Merge pull request #6791 from getkirby/v5/changes/version-create-fix
27033c5 
Add the latest version of a translation automatically
@bastianallgeier @distantnative
Move lock wildcard into the Lock::for method
a448c4b
@distantnative
Add unit test
16db1a9
@distantnative
Fix Lock::for()
695a4ab
@bastianallgeier
Merge pull request #6792 from getkirby/v5/changes/lock-fix
13100f0 
Move lock wildcard into the Lock::for method
@bastianallgeier
Compare form values in Version::isIdentical
8d27f55
@bastianallgeier
Make sure to pass the language correctly in all places
95654dc
@bastianallgeier
Don’t send API requests if there’s no api definition
003ec3c
@distantnative
Revert content.api checks
cbcb705
@distantnative
Merge pull request #6794 from getkirby/v5/changes/version-is-identica…
9d2041e 
…l-fix

Version::isIdentical now uses form values to check for identical versions
@bastianallgeier @distantnative
Fixed k-progress css
c102b12
@bastianallgeier @distantnative
Language dropdown prototype in lab
ff6ba84
@distantnative
Integrate first parts into k-languages-dropdown
4900e5c
@distantnative
Languages dropdown: use i18n strings
6f048ec
@distantnative
Fix languages dropdown unit tests
4958308
@distantnative
Dropdown content item slot
3bc7e87
@bastianallgeier @distantnative
Design changes for the dropdown
d667eff
@bastianallgeier @distantnative
Consider the lock status of any translation
873c02e
@distantnative
Remove old Lab example
e95b22f
@distantnative
Revert "Consider the lock status of any translation"
1d2cbe6 
This reverts commit 873c02e.
@distantnative
Improve docblock LanguagesDropdown::hasChanges
65716d4
@distantnative
Merge pull request #6793 from getkirby/v5/changes/languages-dropdown
8f1db29 
Languages dropdown with changes/lock indicator
@distantnative
FormControls: fix error for preview prop type
e369e77
@distantnative
Improve test coverage
8fef235
@bastianallgeier
Remove non-existing permissions check
d7e37fc
@bastianallgeier
Merge pull request #6796 from getkirby/v5/changes/fix-form-controls-p…
d84d341 
…review-type

FormControls: fix error for preview prop type
@bastianallgeier bastianallgeier added this to the 5.0.0-alpha.4 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0-alpha.4
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier