-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Node 16+ while building/testing on Node 20 #596
Conversation
bb19fc6
to
f5c2e7d
Compare
@chadlwilson Thank you for contributing to gauge-js. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
f5c2e7d
to
1b49a32
Compare
…h in Node 20 Fast path doesn't appear to check encoding options case insensitive, 'utf8' seems more canonical. Signed-off-by: Chad Wilson <[email protected]>
1b49a32
to
67c6f7a
Compare
67c6f7a
to
129b286
Compare
Currently I realised there is a problem with the use of |
See tschaub/mock-fs#377 Signed-off-by: Chad Wilson <[email protected]>
Node 16 is nearly EOL, and Node 20 is nearly LTS, so let's go straight there. This remove use of a deprecated npm flag, replacing with alternative compatible with npm 7/NodeJS 16 onwards (2021+, Node 16 recently went EOL in Sep 2023). The package-lock is also now only compatible with Node 16/npm 7 onwards. Since this is technically a breaking change in npm/node compatibility, bumps the major version and updates the documentation as such. Signed-off-by: Chad Wilson <[email protected]>
129b286
to
ea9086a
Compare
Moved the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Node 16 is nearly EOL, and Node 20 is nearly LTS, so let's go straight there.
This PR also changes the way the plugin installs via gauge to use
--omit=dev
which is preferred above--production
, which requires npm v7+. Since npm 7+ comes with NodeJS 15+ and NodeJS 16 is now EOL, this shouldn't be a concern, but bumping the plugin major version anyway, since this is technically not backward compatible.