Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to use async friendly datastore #44

Closed
wants to merge 1 commit into from
Closed

Conversation

sriv
Copy link
Member

@sriv sriv commented Sep 6, 2024

this comes as a property because I could not find a way to detect this automagically

this comes as a property because I could not find a way to detect this automagically

Signed-off-by: sriv-e6x <[email protected]>
@gaugebot
Copy link

gaugebot bot commented Sep 6, 2024

@sriv Thank you for contributing to gauge-csharp-lib. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@mpekurny
Copy link
Contributor

mpekurny commented Sep 6, 2024

Will this work with multithreaded runs? Since this is switching it from a thread local to a static value, all threads would access the same dictionary. If multiple steps/scenario/specs are running, they would all access the same data store, correct?

@chadlwilson
Copy link
Contributor

Believe this isn't required now as there is an alternate solution proposed and merged in #45, so will close this for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants