-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes for the carbon simulations in GCClassic and GCHP #2554
base: dev/no-diff-to-benchmark
Are you sure you want to change the base?
Conversation
…mbustion emissions The emission for GHGI_EE_COAST_OTHER_MCOMB in HEMCO_Config.rc.CH4 was incorrectly assigned a hierarcy of 100 (added to regional US emissions) when it should have been 1 (added to EDGAR global emissions). The wrong mask was also applied to this field - it should be 1009 (CONUS_MASK_MIRROR) and not 1008 (CONUS_MASK). These typos caused mobile combustion emissions to be double counted over the US. The typos were not present in the HEMCO_Config.rc files for carbon simulations. Also made other white space and comment updates to HEMCO_Config.rc files for the carbon and CH4 simulations to ensure consistency between the two simulations. Signed-off-by: Melissa Sulprizio <[email protected]>
…n against carbon simulation The carbon simulation currently uses GFED biomass burning emissions by default (for all carbon species). It also uses GEOS-Chem v5 OH which is currently required for CH4 in the carbon simulation. To simplify validation of the CO in the tagCO simulation vs the carbon simulation, we update the HEMCO_Config.rc.tagCO to use the same options. Also made a minor change to the OCS biomass burning diagnostic name for consistency with the other carbon species. Signed-off-by: Melissa Sulprizio <[email protected]>
This update prevents printing a message every timestep intended only to be printed once. Signed-off-by: Lizzie Lundgren <[email protected]>
The activate flag is needed in the transport menu since it is used to set Input_Opt%LTRAN. This update fixes a bug that caused mixing ratio update with pressure ratio every timestep. Signed-off-by: Lizzie Lundgren <[email protected]>
…lassic The scale factor is removed from HEMCO_Config.rc since the conversion happens automatically in HEMCO read for GC-Classic. For GCHP the scale factor is now configured in ExtData.rc. Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
All emissions for OCS are surface so total can be 2-dimensional rather than 3-dimensional. Signed-off-by: Lizzie Lundgren <[email protected]>
@msulprizio I can successfully compile GCHP 14.5.0, but when I include these bug fixes, the following error appears. [ 93%] Building Fortran object src/GCHP_GridComp/GEOSChem_GridComp/geos-chem/GeosCore/CMakeFiles/GeosCore.dir/emissions_mod.F90.o |
Signed-off-by: Lizzie Lundgren <[email protected]>
Name and Institution (Required)
Name: Melissa Sulprizio & Lizzie Lundgren
Institution: Harvard University
Describe the update
This pull request contains several fixes and updates to the carbon simulation to (1) reproduce carbon species in the GCClassic standalone CH4, CO2, and tagCO simulations and (2) ensure consistent results between the carbon simulation in GCClassic and GCHP.
Expected changes
These changes impact only the carbon, CH4, CO2, and tagCO simulations and do not impact the full-chemistry benchmark simulations.
Related Github Issue