GCHP carbon simulation fixes #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data in molec/cm2/s is converted to kg/m2/s automatically if reading data in through HEMCO. Since GCHP does not use HEMCO for data read we need to instead specify a scaling factor in a configuration file. This update fixes a bug in GCHP carbon simulations where CH4 emissions were applied in the wrong units. This commit also fixes a bug where several ExtData.rc entries for gridded GHGI v2 Express Extension emissions were specified as monthly when they are actually annual. Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
lizziel
added
topic: GCHP
|
Integration tests are running now |
|
All GCClassic and GCHP integrations pass |
msulprizio
changed the base branch from
dev/no-diff-to-benchmark
to
dev/14.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This PR contains fixes for the GCHP carbon simulation introduced in version 14, not to be confused with the CO2 w/ fluxes simulation option used for the adjoint.
There is a companion MAPL PR that should be merged at the same time as this PR to include all GCHP carbon bug fixes.
geoschem/MAPL#37
Expected changes
This is a no diff update for GC-Classic. Changes only impact the carbon simulation in GCHP.
Reference(s)
None
Related Github Issues
closes geoschem/GCHP#440
closes geoschem/GCHP#437
closes geoschem/GCHP#429