Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw a CMake error if FAST-JX is used for any KPP mechanism except Hg #426

Closed
wants to merge 7 commits into from

Commits on Jul 8, 2024

  1. GEOS-Chem submod update: Merge PR #2363 (Update setCommonRunSettings.sh)

    This commit informs the GCHP superproject about the following
    commits that were pushed to the GitHub geoschem/geos-chem repository:
    
    8554d3a30 Merge PR #2363 (Update setCommonRunSettings.sh.template)
    
    This PR implements a hotfix for an issue where GCHP simulations always
    "thought" that they were using mass fluxes regardless of the met field
    option chosen.
    
    Signed-off-by: Bob Yantosca <[email protected]>
    yantosca committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    9c77f30 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. GEOS-Chem submod update: Merge PR #2342 and Cloud-J PR #17

    This commit informs the GCHP superproject about the following
    commits that were pushed to the GitHub geoschem/geos-chem repository:
    
    f78052f59 Merge PR #2342 (Read number of levels with clouds into Cloud-J)
    
    and to the geoschem/Cloud-J repository:
    
    2d75997 Merge pull request #17 from geoschem/feature/set_levels_with_cloud_from_parent_model
    8a3b925 Update .zenodo.json; add license badge to README
    d93a5aa Add Zenodo file for DOI generation
    42b31ea Update version and add release date for 7.7.1
    c9cbe9a Update README.md
    
    These PRs allow you to specify the number of levels with cloud for
    Cloud-J.  This number is different depending on which instance of
    GEOS-Chem you are using (GCClassic, GCHP, CESM, WRF-GC, etc).
    
    Signed-off-by: Bob Yantosca <[email protected]>
    yantosca committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    6eb1110 View commit details
    Browse the repository at this point in the history
  2. Submod updates: Merge GEOS-Chem PR #2353 and Cloud-J PR #19

    This commit informs the GCHP superproject about the following
    commits that were pushed to the GitHub geoschem/geos-chem repository:
    
    5b3987feb Merge PR #2353 (Cloud-J error handling)
    
    And to the geoschem/Cloud-J repository:
    
    5eabcbe Merge pull request #19 from geoschem/feature/error_handling
    
    These PRs return the error code from Cloud-J all the way out to the
    main program, where the simulation can be terminated gracefully.
    
    Signed-off-by: Bob Yantosca <[email protected]>
    yantosca committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    493b4fd View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Configuration menu
    Copy the full SHA
    a96673e View commit details
    Browse the repository at this point in the history
  2. Submod updates: Merge MAPL PRs #35 and #36 (prefetch debug; hflux bug…

    … fix)
    
    hflux is horizontal flux regridding.
    
    Signed-off-by: Lizzie Lundgren <[email protected]>
    lizziel committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    2fd25ee View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. GEOS-Chem submod update: Merge PR #2369 (Fixes for satellite diags)

    This commit informs the GCHP superproject about the following
    commits that were pushed to the GitHub geoschem/geos-chem repository:
    
    7e4001658 Merge PR #2369 (Fix several issues with satellite diagnostics)
    
    This PR resolves several outstanding issues with the GEOS-Chem Classic
    satellite diagnostics.
    
    Signed-off-by: Bob Yantosca <[email protected]>
    yantosca committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    95a745c View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Throw a CMake error if FAST-JX is used for any mech except Hg

    src/GCHP_GridComp/GEOSChem_GridComp/CMakeLists.txt
    - Add an if block to throw a fatal error if the FASTJX compile option
      is selected for fullchem, custom, or carbon simulations.  Fullchem
      and custom mechanisms use Cloud-J.  We still need to use the FAST-JX
      photolysis scheme with Hg pending input file updates.
    
    CHANGELOG.md
    - Updated accordingly
    
    Signed-off-by: Bob Yantosca <[email protected]>
    yantosca committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    481ea94 View commit details
    Browse the repository at this point in the history