Throw a CMake error if FAST-JX is used for any KPP mechanism except Hg #62
Conversation
CMakeScripts/GC-ConfigureClassic.cmake - Add an if block to throw a fatal error if the FASTJX compile option is selected for fullchem, custom, or carbon simulations. Fullchem and custom mechanisms use Cloud-J. We still need to use the FAST-JX photolysis scheme with Hg pending input file updates. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
yantosca
added
category: Feature Request
yantosca
changed the title
|
Integration tests are in progress. |
|
All GEOS-Chem integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #655527d Merge PR #62 (Throw error if FAST-JX is used w/ non-Hg mechanisms)
GEOS-Chem #03287a67a Merge PR #2372 (Turn off MEGAN extension for non-benchmark sims)
HEMCO #2192e0e HEMCO 3.9.1 release
Using 24 OpenMP threads
Number of execution tests: 28
Submitted as SLURM job: 39695010
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%All tests were identical to PR #2372 except:
|
| @@ -6,6 +6,10 @@ This file documents all notable changes to the GEOS-Chem Classic wrapper reposit | |||
|
|
|||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [Unreleased] - TBD | |||
| ### Changed | |||
| - CMake now throws an error if FAST-JX is used with any other mechanism than Hg | |||
There was a problem hiding this comment.
Could this be changed to simply "Discontinue support of FAST-JX for all but mercury simulations". This will make it more clear to users what the change is.
There was a problem hiding this comment.
There should be a GEOS-Chem PR that goes with this to remove the option for FAST-JX except for mercury.
There was a problem hiding this comment.
Thanks @lizziel. I'm not sure how to implement a GEOS-Chem PR that would prevent use of FAST-JX in the GEOS-Chem repo. There is no good way to compare strings in preprocessor statements (i.e. #if MECH == "Hg" won't work).
What I could do is to remove the FAST-JX CMake compile option and then set FASTJX=1 if -DMECH=Hg is passed at the command line. This would disable FAST_JX for all mechanisms except Hg.
There was a problem hiding this comment.
I would like to keep the compile option so that it is easy for Hg developers to switch between the two. What I was thinking was put an error message within a FASTJX ifdef that if not a mercury simulation then fail. We need this for uses of GEOS-Chem outside of the GC-Classic and GCHP super-projects.
There was a problem hiding this comment.
To further clarify, this would use the Input_Opt logical for Hg simulation, not the compile-time MECH setting.
|
Thanks @lizziel. I can do that. |
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Describe the update
This PR adds an error trap that causes CMake to throw an error if the FASTJX compile option is selected for any mechanism except Hg.
Expected changes
Configuring with the
-DFASTJX=yoption now throws an error message such as:Related Github Issue