Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.12.0? #191

Closed
wants to merge 3 commits into from
Closed

Release v0.12.0? #191

wants to merge 3 commits into from

Conversation

michaelkirk
Copy link
Member

I've drafted up some release notes.

We still have a couple nearly-merged PR's that would be good to include.

#188, #189, #190

What do people think?

@michaelkirk
Fix clippy: remove superfluous use statements
5c8a841 
These modules only contain trait implementations, which don't need to be
`use`'d
@michaelkirk
expose feature for gdal with bindgen
a224cdd 
This is necessary for linking against gdal versions whose bindings
aren't yet included in gdal-sys, which is common when using a newly
released gdal.

Also removed redundant gdal-sys dependency - gdal already includes that,
and geozero doesn't use it directly.
@michaelkirk
Release notes
f1c64ff
@michaelkirk michaelkirk marked this pull request as draft January 10, 2024 23:40
@kylebarron
Copy link
Member

I'm happy to get more of my PRs resolved before the 0.12 release, but I need some more feedback. I don't know what the appetite for breaking changes is, but if there isn't much appetite for breaking changes, then #184 can be closed and #183 might be able to be finished

@michaelkirk
Copy link
Member Author

I don't know what the appetite for breaking changes is, but if there isn't much appetite for breaking changes, then #184 can be closed

I hit the same confusion: https://github.com/michaelkirk/geomedea/blob/main/geomedea_geozero/src/geozero_reader.rs#L92

I think I'm in favor of the change - in my experience, the existing behavior is surprising and leads to bugs. Part of making that change would be updating all the formats in this repo and ideally notifying any others that we know of.

That said, there's no reason I know of that it has to happen in this release.

re: #183 - I'll review shortly.

@kylebarron
Copy link
Member

I hit the same confusion: https://github.com/michaelkirk/geomedea/blob/main/geomedea_geozero/src/geozero_reader.rs#L92

😅

I think I'm in favor of the change - in my experience, the existing behavior is surprising and leads to bugs. Part of making that change would be updating all the formats in this repo and ideally notifying any others that we know of.

That said, there's no reason I know of that it has to happen in this release.

I agree that I'm in favor of the change, agree that it's a bigger lift because you have to ensure writers are up to date, and agree it doesn't need to happen in this release.

@kylebarron
Copy link
Member

Once we have #186 merged, I'd love to get an 0.12 release out! Let me know if I can help with this at all

@kylebarron kylebarron mentioned this pull request Feb 12, 2024
Merged
@kylebarron
Copy link
Member

I created #196 with an updated changelog from some of my recent PRs. Feel free to merge those changes back in here if you'd prefer.

@michaelkirk
Copy link
Member Author

superseded by #196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelkirk @kylebarron