-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Ewkt dialect #155
Merged
Merged
Adds Ewkt dialect #155
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
048dc6f
Add Wkt and Ewkt dialects
Oreilles fbde937
Fix formatting
Oreilles c670618
Remove WktReader lifetime
Oreilles be0534e
Simplify `WktDialect` default declaration
Oreilles fd840fc
Revert `WktWriter::new` signature and adds`WktWriter::with_dialect`
Oreilles c6c37a2
Revert "Remove WktReader lifetime"
Oreilles 06ee5f4
Remove unused imports
Oreilles 8b2594f
Revert gdal line_3d test
Oreilles 6a8b966
Revert `WktString::from_wkb` `writer` declaration
Oreilles f4e32cc
Add new dialects to Format conversion overview documentation
Oreilles 24eca0d
fix build
nyurik 116f438
fix CI build
nyurik 4f2c505
fix ewkt - take 2
nyurik 36dee84
a few suggestions
nyurik 66b5c1e
Merge pull request #2 from nyurik/ewkt-suggestions
Oreilles File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if actionable, just checking if this is correct: both the writer and the processor need a dialect? And when reading, the processor cannot auto-detect the dialect, or can it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So an
Ewkt
string can be parsed from severalWkb
dialects, which is why we need to pass it as a parameter. In the current implementation, no detection of theWkb
dialect is implemented; I guess it would be pretty tricky to do so, as they all have their own quirks.