Add rstar MultiPolygon compat #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urschrei
force-pushed
the
rstar_multipolygon
branch
from
e42f586
to
d6f0d5a
Compare
frewsxcv
approved these changes
Nov 5, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
Add rstar MultiPolygon compat
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Now what |
michaelkirk
approved these changes
Nov 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Still seeing the concave hull test failure in the merge queue |
|
The concave hull algorithm uses an rtree, and we bumped rstar yesterday with some bug fixes. But why is the test passing here and failing in the merge queue? |
|
Can anyone reproduce it locally? |
|
Yep just managed to reproduce it on HEAD in |
|
Yeah it's the rstar patch version: https://github.com/georust/rstar/blob/master/rstar/CHANGELOG.md Not immediately obvious what change is causing this though. Pinning to 0.12.0 causes tests to pass. |
|
I'm putting my notes about the CI failure in a dedicated issue: #1260 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.This should merge before #1246