Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ME]: Revert dump #968

Merged
merged 5 commits into from
Aug 26, 2024
Merged

[ME]: Revert dump #968

merged 5 commits into from
Aug 26, 2024

Conversation

cmoinier
Copy link
Collaborator

Description

This PR reverts the dump added in #957 to use the latest dump from main (before PR was merged). It adds the change done in the PR to have the license field e2e tests work, though.

Architectural changes

The following library now depends on [...]

Screenshots

[...]

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by Organization ABC.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 24, 2024 •
edited
Loading

Affected libs: database-dump,
Affected apps: ``,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 24, 2024 •
edited
Loading

📷 Screenshots are here!

@jahow jahow force-pushed the ME/revert-dump branch 4 times, most recently from eb34337 to 5a93896 Compare August 26, 2024 09:28
@jahow
ci: run tests for both apps in parallel with a new database each time
7072122
@jahow
chore: remove the dependsOn link between e2e tests
afe9458
@jahow
chore: update dump again
5773867 
The dump was regenerated from origin/main (commit c8c4ee7), and then an "etalab"
licence was added to the accroche_velos record. This was done in the GN
legacy editor
@jahow
chore: add a dependency of the e2e projects to the database dump
58890f5 
This means the tests will not be run from cache if the dump is changed (even
if no code change happens)
@jahow
Copy link
Collaborator

jahow commented Aug 26, 2024

@cmoinier this is what I have added:

  • the e2e projects (datahub and editor) now have a dependency to the database dump; this means that if the dump changes, even if nothing else is changed in the project, the tests will run again
  • the e2e tests for both apps are now run in parallel in separate runners to be 100% sure that there is no interaction between them because they would use the same database
  • the dump was regenerated again; I feel like the way we modify records in the dump is very sensitive, so I tried modified the license of the accroches_velo record in the legacy GN editor and now it appears to be working 🤞

I'm going to merge this now

@jahow jahow merged commit b0bcda8 into main Aug 26, 2024
12 checks passed
@jahow jahow deleted the ME/revert-dump branch August 26, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcaplier rcaplier rcaplier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmoinier @jahow @rcaplier