Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ME: rework markdown parser display to be more generic #961

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

LHBruneton-C2C
Copy link
Collaborator

@LHBruneton-C2C LHBruneton-C2C commented Aug 13, 2024

Description

This PR makes the markdown parser display more generic, and fixes the height in the rich text form field of the metadata editor.

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

Affected libs: ui-elements, feature-notifications, feature-catalog, feature-record, feature-router, feature-editor, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search, ui-layout,
Affected apps: datahub, metadata-editor, demo, webcomponents, map-viewer, search, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Aug 13, 2024

📷 Screenshots are here!

@coveralls
Copy link

Coverage Status

coverage: 83.773% (+0.8%) from 82.94%
when pulling b836a6f on ME/fix-rich-text-preview-overflow
into e079151 on main.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks :)

@LHBruneton-C2C LHBruneton-C2C merged commit caf9e4e into main Aug 13, 2024
8 of 11 checks passed
@LHBruneton-C2C LHBruneton-C2C deleted the ME/fix-rich-text-preview-overflow branch August 13, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants