Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDITOR]: Prefill contact informations with current user #955

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

rcaplier
Copy link
Collaborator

@rcaplier rcaplier commented Aug 1, 2024

Description

This PR makes every new record created prefilled with current connected user as contact for resource with role "point_of_contact".

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

**This work is sponsored by **.

@rcaplier rcaplier self-assigned this Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Affected libs: common-domain, api-metadata-converter, api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, feature-editor, feature-auth, ui-search, common-fixtures, ui-elements, feature-notifications, ui-catalog, util-shared, ui-widgets, ui-inputs, ui-layout, ui-map, ui-dataviz,
Affected apps: metadata-editor, metadata-converter, datafeeder, demo, datahub, webcomponents, map-viewer, search, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Aug 1, 2024

📷 Screenshots are here!

@rcaplier rcaplier marked this pull request as ready for review August 1, 2024 11:53
@rcaplier rcaplier force-pushed the me-prefill-contact-informations-with-current-user branch from 926a26a to 2646249 Compare August 1, 2024 12:07
@rcaplier rcaplier force-pushed the me-prefill-contact-informations-with-current-user branch from 2646249 to eb067e6 Compare August 22, 2024 13:54
@coveralls
Copy link

coveralls commented Aug 22, 2024

Coverage Status

coverage: 83.031% (+1.7%) from 81.367%
when pulling 6e317bc on me-prefill-contact-informations-with-current-user
into 7a893ad on main.

@rcaplier rcaplier force-pushed the me-prefill-contact-informations-with-current-user branch 11 times, most recently from de199a6 to e65998c Compare August 26, 2024 14:38
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great work!!

Comment on lines +4 to +11
export const REGION_HAUT_DE_FRANCE_ORG_FIXTURE = (): Organization => ({
name: 'Région Hauts-de-France',
description: 'A very sweet description about Région Hauts-de-France.',
email: '[email protected]',
website: new URL('https://region-haut-de-france.com/'),
logoUrl: new URL('https://region-haut-de-france.com/logo.png'),
recordCount: 4,
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be beneficial to agree on a way to write our fixtures. The original approach was to use deepFreeze to avoid mutating fixtures between tests; creating an object each time makes sense too but it'd be better not to mix these practices too much to avoid confusion

@rcaplier rcaplier force-pushed the me-prefill-contact-informations-with-current-user branch from e65998c to 6e317bc Compare August 29, 2024 06:24
@rcaplier rcaplier merged commit e97caaf into main Aug 29, 2024
12 checks passed
@rcaplier rcaplier deleted the me-prefill-contact-informations-with-current-user branch August 29, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants