Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add templates for issues and PR #774

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Add templates for issues and PR #774

merged 1 commit into from
Jan 19, 2024

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Jan 18, 2024

This PR adds templates for issues (bug and proposal) as well as a template for PRs with a QA checklist.

Copy link
Contributor

github-actions bot commented Jan 18, 2024

Affected libs: , Affected apps: ,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the lifecycle of this kind of request ?
Like any development would need funding.

It's not clear if someone wants to add a feature, or expect us to implement his feature.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not supposed to be for request, but for proposal. It says "a feature or task that you intend to push forward".

Basically this is meant for people that have the funding/time to implement something and want to get approval from the project.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a separate proposal.md template for proposals with funding, and the feature_request template is now for requests/suggestions but without actual funding/intention to contribute.

@jahow jahow force-pushed the add-templates branch 3 times, most recently from c8ca1d3 to 7c31410 Compare January 18, 2024 12:51
@jahow jahow merged commit 886aae6 into main Jan 19, 2024
5 of 6 checks passed
@jahow jahow deleted the add-templates branch January 19, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants