Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Nx 17 & Angular 17 #688

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,5 @@ docs/.vitepress/dist
docs/.vitepress/cache

apps/*-e2e/cypress/**

.nx/cache
2 changes: 2 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@
/docs/.vitepress/dist
# OpenAPI generated specs
**/spec.yaml

/.nx/cache
11 changes: 2 additions & 9 deletions apps/data-platform/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
}
},
"lint": {
"executor": "@nx/linter:eslint",
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"],
"options": {
"lintFilePatterns": ["apps/data-platform/**/*.ts"]
Expand All @@ -47,14 +47,7 @@
"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
"options": {
"jestConfig": "apps/data-platform/jest.config.ts",
"passWithNoTests": true
},
"configurations": {
"ci": {
"ci": true,
"codeCoverage": true
}
"jestConfig": "apps/data-platform/jest.config.ts"
}
},
"docker-build": {
Expand Down
13 changes: 6 additions & 7 deletions apps/datafeeder/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,23 +68,23 @@
"executor": "@angular-devkit/build-angular:dev-server",
"configurations": {
"production": {
"browserTarget": "datafeeder:build:production"
"buildTarget": "datafeeder:build:production"
},
"development": {
"browserTarget": "datafeeder:build:development",
"proxyConfig": "proxy-config.js"
"proxyConfig": "proxy-config.js",
"buildTarget": "datafeeder:build:development"
}
},
"defaultConfiguration": "development"
},
"extract-i18n": {
"executor": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "datafeeder:build"
"buildTarget": "datafeeder:build"
}
},
"lint": {
"executor": "@nx/linter:eslint",
"executor": "@nx/eslint:lint",
"options": {
"lintFilePatterns": [
"apps/datafeeder/src/**/*.ts",
Expand All @@ -97,8 +97,7 @@
"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/apps/datafeeder"],
"options": {
"jestConfig": "apps/datafeeder/jest.config.ts",
"passWithNoTests": true
"jestConfig": "apps/datafeeder/jest.config.ts"
}
},
"docker-build": {
Expand Down
2 changes: 1 addition & 1 deletion apps/datahub-e2e/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
}
},
"lint": {
"executor": "@nx/linter:eslint",
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"],
"options": {
"lintFilePatterns": ["apps/datahub-e2e/**/*.{js,ts}"]
Expand Down
13 changes: 6 additions & 7 deletions apps/datahub/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,23 +83,23 @@
"executor": "@angular-devkit/build-angular:dev-server",
"configurations": {
"production": {
"browserTarget": "datahub:build:production"
"buildTarget": "datahub:build:production"
},
"development": {
"browserTarget": "datahub:build:development",
"proxyConfig": "proxy-config.js"
"proxyConfig": "proxy-config.js",
"buildTarget": "datahub:build:development"
}
},
"defaultConfiguration": "development"
},
"extract-i18n": {
"executor": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "datahub:build"
"buildTarget": "datahub:build"
}
},
"lint": {
"executor": "@nx/linter:eslint",
"executor": "@nx/eslint:lint",
"options": {
"lintFilePatterns": [
"apps/datahub/src/**/*.ts",
Expand All @@ -112,8 +112,7 @@
"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/apps/datahub"],
"options": {
"jestConfig": "apps/datahub/jest.config.ts",
"passWithNoTests": true
"jestConfig": "apps/datahub/jest.config.ts"
}
},
"docker-build": {
Expand Down
11 changes: 5 additions & 6 deletions apps/demo/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,22 +67,22 @@
"executor": "@angular-devkit/build-angular:dev-server",
"configurations": {
"production": {
"browserTarget": "demo:build:production"
"buildTarget": "demo:build:production"
},
"development": {
"browserTarget": "demo:build:development"
"buildTarget": "demo:build:development"
}
},
"defaultConfiguration": "development"
},
"extract-i18n": {
"executor": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "demo:build"
"buildTarget": "demo:build"
}
},
"lint": {
"executor": "@nx/linter:eslint",
"executor": "@nx/eslint:lint",
"options": {
"lintFilePatterns": ["apps/demo/src/**/*.ts", "apps/demo/src/**/*.html"]
},
Expand All @@ -92,8 +92,7 @@
"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/apps/demo"],
"options": {
"jestConfig": "apps/demo/jest.config.ts",
"passWithNoTests": true
"jestConfig": "apps/demo/jest.config.ts"
}
},
"storybook": {
Expand Down
4 changes: 2 additions & 2 deletions apps/demo/src/app/app.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,10 @@ <h2>Next Steps</h2>
<summary>Add UI library</summary>
<pre>
# Generate UI lib
nx g @nx/angular:lib ui
nx g &#64;nx/angular:lib ui

# Add a component
nx g @nx/angular:component xyz --project ui</pre
nx g &#64;nx/angular:component xyz --project ui</pre
>
</details>
<details>
Expand Down
13 changes: 6 additions & 7 deletions apps/map-viewer/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,23 +68,23 @@
"executor": "@angular-devkit/build-angular:dev-server",
"configurations": {
"production": {
"browserTarget": "map-viewer:build:production"
"buildTarget": "map-viewer:build:production"
},
"development": {
"browserTarget": "map-viewer:build:development",
"proxyConfig": "proxy-config.js"
"proxyConfig": "proxy-config.js",
"buildTarget": "map-viewer:build:development"
}
},
"defaultConfiguration": "development"
},
"extract-i18n": {
"executor": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "map-viewer:build"
"buildTarget": "map-viewer:build"
}
},
"lint": {
"executor": "@nx/linter:eslint",
"executor": "@nx/eslint:lint",
"options": {
"lintFilePatterns": [
"apps/map-viewer/src/**/*.ts",
Expand All @@ -96,8 +96,7 @@
"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/apps/map-viewer"],
"options": {
"jestConfig": "apps/map-viewer/jest.config.ts",
"passWithNoTests": true
"jestConfig": "apps/map-viewer/jest.config.ts"
}
}
},
Expand Down
11 changes: 5 additions & 6 deletions apps/metadata-converter/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,22 +62,22 @@
"executor": "@angular-devkit/build-angular:dev-server",
"configurations": {
"production": {
"browserTarget": "metadata-converter:build:production"
"buildTarget": "metadata-converter:build:production"
},
"development": {
"browserTarget": "metadata-converter:build:development"
"buildTarget": "metadata-converter:build:development"
}
},
"defaultConfiguration": "development"
},
"extract-i18n": {
"executor": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "metadata-converter:build"
"buildTarget": "metadata-converter:build"
}
},
"lint": {
"executor": "@nx/linter:eslint",
"executor": "@nx/eslint:lint",
"options": {
"lintFilePatterns": [
"apps/metadata-converter/**/*.ts",
Expand All @@ -89,8 +89,7 @@
"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/apps/metadata-converter"],
"options": {
"jestConfig": "apps/metadata-converter/jest.config.ts",
"passWithNoTests": true
"jestConfig": "apps/metadata-converter/jest.config.ts"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion apps/metadata-editor-e2e/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
}
},
"lint": {
"executor": "@nx/linter:eslint",
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"],
"options": {
"lintFilePatterns": ["apps/metadata-editor-e2e/**/*.{js,ts}"]
Expand Down
13 changes: 6 additions & 7 deletions apps/metadata-editor/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,23 +72,23 @@
"executor": "@angular-devkit/build-angular:dev-server",
"configurations": {
"production": {
"browserTarget": "metadata-editor:build:production"
"buildTarget": "metadata-editor:build:production"
},
"development": {
"browserTarget": "metadata-editor:build:development",
"proxyConfig": "proxy-config.js"
"proxyConfig": "proxy-config.js",
"buildTarget": "metadata-editor:build:development"
}
},
"defaultConfiguration": "development"
},
"extract-i18n": {
"executor": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "metadata-editor:build"
"buildTarget": "metadata-editor:build"
}
},
"lint": {
"executor": "@nx/linter:eslint",
"executor": "@nx/eslint:lint",
"options": {
"lintFilePatterns": [
"apps/metadata-editor/**/*.ts",
Expand All @@ -100,8 +100,7 @@
"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
"options": {
"jestConfig": "apps/metadata-editor/jest.config.ts",
"passWithNoTests": true
"jestConfig": "apps/metadata-editor/jest.config.ts"
}
}
},
Expand Down
13 changes: 6 additions & 7 deletions apps/search/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,23 +59,23 @@
"executor": "@angular-devkit/build-angular:dev-server",
"configurations": {
"production": {
"browserTarget": "search:build:production"
"buildTarget": "search:build:production"
},
"development": {
"browserTarget": "search:build:development",
"proxyConfig": "proxy-config.js"
"proxyConfig": "proxy-config.js",
"buildTarget": "search:build:development"
}
},
"defaultConfiguration": "development"
},
"extract-i18n": {
"executor": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "search:build"
"buildTarget": "search:build"
}
},
"lint": {
"executor": "@nx/linter:eslint",
"executor": "@nx/eslint:lint",
"options": {
"lintFilePatterns": [
"apps/search/src/**/*.ts",
Expand All @@ -88,8 +88,7 @@
"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/apps/search"],
"options": {
"jestConfig": "apps/search/jest.config.ts",
"passWithNoTests": true
"jestConfig": "apps/search/jest.config.ts"
}
}
},
Expand Down
11 changes: 5 additions & 6 deletions apps/webcomponents/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,22 +64,22 @@
"executor": "@angular-devkit/build-angular:dev-server",
"configurations": {
"production": {
"browserTarget": "webcomponents:build:production"
"buildTarget": "webcomponents:build:production"
},
"development": {
"browserTarget": "webcomponents:build:development"
"buildTarget": "webcomponents:build:development"
}
},
"defaultConfiguration": "development"
},
"extract-i18n": {
"executor": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "webcomponents:build"
"buildTarget": "webcomponents:build"
}
},
"lint": {
"executor": "@nx/linter:eslint",
"executor": "@nx/eslint:lint",
"options": {
"lintFilePatterns": [
"apps/webcomponents/src/**/*.ts",
Expand All @@ -92,8 +92,7 @@
"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/apps/webcomponents"],
"options": {
"jestConfig": "apps/webcomponents/jest.config.ts",
"passWithNoTests": true
"jestConfig": "apps/webcomponents/jest.config.ts"
}
},
"storybook": {
Expand Down
5 changes: 2 additions & 3 deletions libs/api/metadata-converter/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"projectType": "library",
"targets": {
"lint": {
"executor": "@nx/linter:eslint",
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"],
"options": {
"lintFilePatterns": ["libs/api/metadata-converter/**/*.ts"]
Expand All @@ -15,8 +15,7 @@
"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/libs/api/metadata-converter"],
"options": {
"jestConfig": "libs/api/metadata-converter/jest.config.ts",
"passWithNoTests": true
"jestConfig": "libs/api/metadata-converter/jest.config.ts"
}
}
},
Expand Down
Loading
Loading