Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DH): Improve plurals in text #686

Merged
merged 2 commits into from
Nov 15, 2023
Merged

feat(DH): Improve plurals in text #686

merged 2 commits into from
Nov 15, 2023

Conversation

Angi-Kinas
Copy link
Collaborator

image
image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2023 •
edited
Loading

Affected libs: ui-dataviz, feature-dataviz, feature-record, feature-router, ui-search, feature-search, feature-map,
Affected apps: datahub, metadata-editor, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Nov 13, 2023 •
edited
Loading

Coverage Status

coverage: 86.794% (+0.2%) from 86.643%
when pulling 2b3620d on DH-handle-plurals-translations
into 295eda8 on main.

tkohr
tkohr approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Angi-Kinas ! Maybe you could adapt de de.json accordingly as well ?

@Angi-Kinas Angi-Kinas merged commit 8adb96d into main Nov 15, 2023
6 checks passed
@Angi-Kinas Angi-Kinas deleted the DH-handle-plurals-translations branch November 15, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkohr tkohr tkohr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Angi-Kinas @coveralls @tkohr