Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub (fix): Display UpdateFrequencyCustom correctly #679

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Nov 10, 2023

The PR fixes UpdateFrequencys (like annualy from GN4) that are handled as objects in gn-ui.

before:
updateFrequency

after:
updateFrequency_after

Copy link
Contributor

github-actions bot commented Nov 10, 2023

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

translations/fr.json Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 86.636% (+0.02%) from 86.617%
when pulling beaed19 on update-frequency-custom
into 5f1c197 on main.

@fgravin
Copy link
Member

fgravin commented Nov 10, 2023

Thanks @tkohr, the status of the data has changed between the 2 screenshots 😄

Small detail but I find the "d'ou viennent ces données" layout a bit weird. Can you give the uuid of the record please ?
We should not return to the line in the middle of a link, start at the beginning of the line and use ellipsis if need, and it's weird the / at the end and the BDTOPO.2020-11

@tkohr
Copy link
Collaborator Author

tkohr commented Nov 13, 2023

Thanks @tkohr, the status of the data has changed between the 2 screenshots 😄

Small detail but I find the "d'ou viennent ces données" layout a bit weird. Can you give the uuid of the record please ? We should not return to the line in the middle of a link, start at the beginning of the line and use ellipsis if need, and it's weird the / at the end and the BDTOPO.2020-11

Here's the record. The different status in the screnshots is related to this fix ;-)

Regarding "d'ou viennent ces données", for me the main issue is that the / is not recognized of being part of the URL and the icon gets squeezed in between. The line break doesn't shock me and allows reading the link.

@tkohr tkohr added bug Something isn't working backport 2.0.x labels Nov 13, 2023
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! I made a suggestion to simplify the code, adapt as you see fit!

@tkohr tkohr merged commit 295eda8 into main Nov 13, 2023
7 checks passed
@tkohr tkohr deleted the update-frequency-custom branch November 13, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants