Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add wrap to home buttons to avoid mobile horizontal scroll #1038

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix: add wrap to home buttons to avoid mobile horizontal scroll #1038

merged 2 commits into from
Nov 14, 2024

Conversation

f-necas
Copy link
Collaborator

@f-necas f-necas commented Nov 13, 2024

Description

This PR introduces flex wrap to home btns to avoid horizontal scrolling in mobile view

Screenshots

From:
image

To:
image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Affected libs: ``,
Affected apps: datahub,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

📷 Screenshots are here!

jahow
jahow approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you please address the failing CI before merging?

@coveralls
Copy link

Coverage Status

coverage: 83.209% (-0.1%) from 83.337%
when pulling e887c3c on wrap-home-btn
into 9ee3821 on main.

@f-necas f-necas merged commit 89e0d3b into main Nov 14, 2024
12 of 13 checks passed
@f-necas f-necas deleted the wrap-home-btn branch November 14, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahow jahow jahow approved these changes

@tkohr tkohr Awaiting requested review from tkohr

@cmoinier cmoinier Awaiting requested review from cmoinier

@Angi-Kinas Angi-Kinas Awaiting requested review from Angi-Kinas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@f-necas @coveralls @jahow