Editor: Add a search filters summary component #1037
Conversation
|
Affected libs:
|
|
📷 Screenshots are here! |
| *ngFor="let fieldValue of dateRange$ | async" | ||
| [removable]="true" | ||
| (badgeRemoveClicked)="removeFilterValue(fieldValue)" | ||
| >{{ fieldValue['start'] }} - >{{ fieldValue['end'] }}</gn-ui-badge |
There was a problem hiding this comment.
This can probably be encapsulated in a "getReadableValue" method to avoid having a ngIf in the template
| const currentFieldValues: (FieldValue | DateRange)[] = await firstValueFrom( | ||
| this.fieldValues$ | ||
| ) | ||
| const updatedFieldValues = currentFieldValues.filter( | ||
| (value: string | DateRange) => value !== fieldValue | ||
| ) | ||
| this.fieldsService | ||
| .buildFiltersFromFieldValues({ | ||
| [this.fieldName]: updatedFieldValues as FieldValue[], | ||
| }) | ||
| .subscribe((filters) => this.searchService.updateFilters(filters)) |
There was a problem hiding this comment.
how about directly modifying the current filters instead of going from filters to values and then values to filters? simply deleting the corresponding key in the filters should be enough
| <md-editor-search-filters-summary-item | ||
| *ngFor="let field of searchFields; let i = index" | ||
| [fieldName]="field" | ||
| ></md-editor-search-filters-summary-item> |
There was a problem hiding this comment.
I would suggest avoiding creating a separate "summary-item" component, and do everything in the search-filters-summary component. Do you think that would be doable?
| import { TranslateModule } from '@ngx-translate/core' | ||
|
|
||
| @Component({ | ||
| selector: 'md-editor-search-filters-summary', |
There was a problem hiding this comment.
this can maybe go in the feature-search lib ?
| @Input() searchFields: string[] = [] | ||
|
|
||
| searchFilterActive$ = this.searchFacade.searchFilters$.pipe( | ||
| map((filters) => this.hasNonEmptyValues(filters)) | ||
| ) |
There was a problem hiding this comment.
I'm wondering if instead of taking a list of filters as input we can simply listen for the search filters and show everyone of them. This means that if another filter (which does not appear in the advanced filters above) is active then it will also show up. What do you think?
| marker('search.filters.summaryLabel.user') | ||
| marker('search.filters.summaryLabel.changeDate') |
There was a problem hiding this comment.
how about marking labels for all fields? It might make more sense taken from outside I think. Another approach would be to use the field normal label if a summaryLabel is not available.
|
Thanks for the suggestions @jahow, I'll have a look how to refactor things this way. |
Description
This PR introduces components to display currently selected search filter values in a zone below the search filters. It is still WIP.
To-dos:
Screenshots
Quality Assurance Checklist
breaking changelabelbackport <release branch>label