-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Clean unfinished UI features #1035
base: main
Are you sure you want to change the base?
Conversation
translations
are not yet implemented and immport record from model
21da448
to
986d906
Compare
Affected libs:
|
📷 Screenshots are here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this cleanup @Angi-Kinas 😃
I had just one deletion suggestion below, but if you decide to keep it you can go ahead and merge!
> | ||
</gn-ui-checkbox> | ||
</ng-template> | ||
<ng-template #header> </ng-template> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to keep this empty ng-template
for structure purposes ? or for later?
Description
This PR removes, uncomments and hides features that are not yet implemented.
The features that are removed:
The features that are uncommented:
Additionally the title help icon is hidden when help text is empty.
Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
labelThis work is sponsored by Organization ABC.