Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Clean unfinished UI features #1035

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Angi-Kinas
Copy link
Collaborator

@Angi-Kinas Angi-Kinas commented Nov 11, 2024

Description

This PR removes, uncomments and hides features that are not yet implemented.
The features that are removed:

  • Multi-select Checkbox for the results table
  • tabs above all records and my records dashboards

The features that are uncommented:

  • elements in the navbar (discussion, calendar)
  • “Not implemented yet” elements of the edit toolbar

Additionally the title help icon is hidden when help text is empty.

Screenshots

image
image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by Organization ABC.

@Angi-Kinas Angi-Kinas force-pushed the ME-clean-unfinished-UI-features branch from 21da448 to 986d906 Compare November 11, 2024 13:34
Copy link
Contributor

github-actions bot commented Nov 11, 2024

Affected libs: feature-editor, ui-search, feature-search, feature-router, feature-map, feature-dataviz, feature-record,
Affected apps: metadata-editor, datafeeder, demo, datahub, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Nov 11, 2024

📷 Screenshots are here!

@coveralls
Copy link

coveralls commented Nov 11, 2024

Coverage Status

coverage: 83.17% (+2.5%) from 80.717%
when pulling 6ad6399 on ME-clean-unfinished-UI-features
into e8eb1e1 on main.

@jahow jahow added this to the 2.4.0 milestone Nov 14, 2024
Copy link
Collaborator

@cmoinier cmoinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this cleanup @Angi-Kinas 😃
I had just one deletion suggestion below, but if you decide to keep it you can go ahead and merge!

>
</gn-ui-checkbox>
</ng-template>
<ng-template #header> </ng-template>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep this empty ng-template for structure purposes ? or for later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants