Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datahub: improvements to the record page (header & abstract) #1028

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Datahub: improvements to the record page (header & abstract) #1028

merged 2 commits into from
Oct 29, 2024

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Oct 25, 2024 •
edited
Loading

Description

This PR brings some visual improvements to the top part of the datahub record page in order to match the Figma mockups:

  • tweaked appearance of the geo-data badge
  • tweaked graphic overview vertical position to be aligned with abstract
  • avoid content cutoff in some cases when abstract is fully expanded
  • better content ghosts when loading the record

Architectural changes

none

Screenshots

image

image

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

Affected libs: ui-elements, feature-notifications, feature-editor, feature-search, feature-router, feature-map, feature-dataviz, feature-record, feature-catalog, ui-catalog, ui-search,
Affected apps: datahub, metadata-editor, demo, webcomponents, search, map-viewer, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

📷 Screenshots are here!

@coveralls
Copy link

coveralls commented Oct 25, 2024 •
edited
Loading

Coverage Status

coverage: 83.264% (-0.6%) from 83.88%
when pulling 5bd5659 on fix-about-readmore-block
into 0c459c1 on main.

cmoinier
cmoinier approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@cmoinier cmoinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of suggestions, otherwise LGTM, thanks! :)

apps/datahub/src/app/record/record-metadata/record-metadata.component.html Outdated Show resolved Hide resolved
libs/ui/elements/src/lib/metadata-info/metadata-info.component.html Show resolved Hide resolved
@cmoinier cmoinier force-pushed the fix-about-readmore-block branch 2 times, most recently from 36ba25b to a4a4fa8 Compare October 29, 2024 16:09
@cmoinier
feat(DH): some improvements to record page
a5d1dce 
Better content ghost
Hide constraints/usage panel and catalog name when loading
Better header layout
Better position of abstract & overview
@jahow jahow merged commit 7e43a35 into main Oct 29, 2024
11 checks passed
@jahow jahow deleted the fix-about-readmore-block branch October 29, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmoinier cmoinier cmoinier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jahow @coveralls @cmoinier